Move CSSRuleCollection class to its own file

Move CSSRuleCollection class to its own file

Committed: https://pdfium.googlesource.com/pdfium/+/69f160df5a13bbf1eb3bd39e59c5890d212f98ad

[npm_g, 2016-07-20 15:44:45]

Description was changed from

==========
Move CSSRuleCollection class to its own file

BUG=
==========

to

==========
Move CSSRuleCollection class to its own file

BUG=
==========

[npm_g, 2016-07-20 15:44:45]

npm@google.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm_g, 2016-07-20 16:04:31]

First submission with very simple change

[dsinclair, 2016-07-20 16:09:03]

Please remove the BUG= line if there is no associated bug.

https://codereview.chromium.org/2166833002/diff/1/xfa/fde/css/fde_cssrulecoll...
File xfa/fde/css/fde_cssrulecollection.cpp (right):

https://codereview.chromium.org/2166833002/diff/1/xfa/fde/css/fde_cssrulecoll...
xfa/fde/css/fde_cssrulecollection.cpp:17: #include
"xfa/fde/css/fde_cssstyleselector.h"
nit: Includes should be in sorted order.

https://codereview.chromium.org/2166833002/diff/1/xfa/fde/css/fde_cssrulecoll...
xfa/fde/css/fde_cssrulecollection.cpp:20: 
The file should be named cfde_cssrulecollection to match the class name.

[npm_g, 2016-07-20 16:42:21]

Description was changed from

==========
Move CSSRuleCollection class to its own file

BUG=
==========

to

==========
Move CSSRuleCollection class to its own file
==========

[npm_g, 2016-07-20 17:04:03]

Addressed changes

https://codereview.chromium.org/2166833002/diff/1/xfa/fde/css/fde_cssrulecoll...
File xfa/fde/css/fde_cssrulecollection.cpp (right):

https://codereview.chromium.org/2166833002/diff/1/xfa/fde/css/fde_cssrulecoll...
xfa/fde/css/fde_cssrulecollection.cpp:17: #include
"xfa/fde/css/fde_cssstyleselector.h"
On 2016/07/20 16:09:02, dsinclair wrote:
> nit: Includes should be in sorted order.

Done.

https://codereview.chromium.org/2166833002/diff/1/xfa/fde/css/fde_cssrulecoll...
xfa/fde/css/fde_cssrulecollection.cpp:20: 
On 2016/07/20 16:09:02, dsinclair wrote:
> The file should be named cfde_cssrulecollection to match the class name.

Done.

[dsinclair, 2016-07-20 17:08:54]

https://codereview.chromium.org/2166833002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2166833002/diff/20001/BUILD.gn#newcode952
BUILD.gn:952: "xfa/fde/css/cfde_cssrulecollection.cpp",
Sorted order.

Running 'git cl format' should sort BUILD.gn entries. It's supposed to prompt
for this on upload.

[npm_g, 2016-07-20 17:17:01]

For now I can run the format command before uploading

https://codereview.chromium.org/2166833002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2166833002/diff/20001/BUILD.gn#newcode952
BUILD.gn:952: "xfa/fde/css/cfde_cssrulecollection.cpp",
On 2016/07/20 17:08:54, dsinclair wrote:
> Sorted order.
> 
> Running 'git cl format' should sort BUILD.gn entries. It's supposed to prompt
> for this on upload.

Done.

[dsinclair, 2016-07-20 17:18:10]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-20 17:18:10]

lgtm

[commit-bot: I haz the power, 2016-07-20 17:18:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 17:48:30]

Description was changed from

==========
Move CSSRuleCollection class to its own file
==========

to

==========
Move CSSRuleCollection class to its own file

Committed:
https://pdfium.googlesource.com/pdfium/+/69f160df5a13bbf1eb3bd39e59c5890d212f...
==========

[commit-bot: I haz the power, 2016-07-20 17:48:31]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/69f160df5a13bbf1eb3bd39e59c5890d212f...