Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 216683002: Correcting value incorrectly logged as video_send. (Closed)

Created:
6 years, 9 months ago by phoglund_chromium
Modified:
6 years, 9 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Correcting value incorrectly logged as video_send. https://codereview.chromium.org/213243002/ had an error where we log the new metrics to the wrong bucket. This should fix that. BUG=352266, 357162 TBR=tommi@chromium.org NOTRY=True (ios_debug broken and tripping up CQ) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260172

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/media/webrtc_browsertest_perf.cc View 1 chunk +5 lines, -5 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
phoglund_chromium
6 years, 9 months ago (2014-03-28 09:22:03 UTC) #1
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 9 months ago (2014-03-28 09:22:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/216683002/1
6 years, 9 months ago (2014-03-28 09:23:57 UTC) #3
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/216683002/diff/1/chrome/browser/media/webrtc_browsertest_perf.cc File chrome/browser/media/webrtc_browsertest_perf.cc (right): https://codereview.chromium.org/216683002/diff/1/chrome/browser/media/webrtc_browsertest_perf.cc#newcode86 chrome/browser/media/webrtc_browsertest_perf.cc:86: perf_test::PrintResult("video_recv", "", "goog_capture_jitter_ms", value, can we have constants ...
6 years, 9 months ago (2014-03-28 09:36:25 UTC) #4
phoglund_chromium
https://codereview.chromium.org/216683002/diff/1/chrome/browser/media/webrtc_browsertest_perf.cc File chrome/browser/media/webrtc_browsertest_perf.cc (right): https://codereview.chromium.org/216683002/diff/1/chrome/browser/media/webrtc_browsertest_perf.cc#newcode86 chrome/browser/media/webrtc_browsertest_perf.cc:86: perf_test::PrintResult("video_recv", "", "goog_capture_jitter_ms", value, On 2014/03/28 09:36:25, tommi wrote: ...
6 years, 9 months ago (2014-03-28 10:05:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 14:21:02 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137273
6 years, 9 months ago (2014-03-28 14:21:02 UTC) #7
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 9 months ago (2014-03-28 14:43:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/216683002/1
6 years, 9 months ago (2014-03-28 14:45:38 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 17:01:31 UTC) #10
Message was sent while issue was closed.
Change committed as 260172

Powered by Google App Engine
This is Rietveld 408576698