Issue 2166823004: Place WaitForPasswordStore() before checking the store/prompt in CredentialManagerBrowserTest*

Issue 2166823004: Place WaitForPasswordStore() before checking the store/prompt in CredentialManagerBrowserTest* (Closed)

Created:
4 years, 5 months ago by vasilii

Modified:
4 years, 5 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Place WaitForPasswordStore() before checking the store/prompt in CredentialManagerBrowserTest* BUG=629459 Committed: https://crrev.com/b853237943857563d2ef66b3dc83bb47c72389d8 Cr-Commit-Position: refs/heads/master@{#407094}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	chrome/browser/password_manager/credential_manager_browsertest.cc	View		3 chunks	+11 lines, -3 lines	0 comments	Download

Total messages: 12 (7 generated)

vasilii

Hi Vaclav, please review. This fixes one of the two reasons why SaveViaAPIAndAutofill failed.

4 years, 5 months ago (2016-07-21 17:58:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166823004/1

4 years, 5 months ago (2016-07-22 07:49:50 UTC) #9

commit-bot: I haz the power

4 years, 5 months ago (2016-07-22 07:55:11 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b853237943857563d2ef66b3dc83bb47c72389d8
Cr-Commit-Position: refs/heads/master@{#407094}