Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2166813006: conic fuzz fix (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

conic fuzz fix If no closest section is found in conic intersection (which can happen if the numbers are out of range) abort the intersection. Also suppress assert fired in this case so it only checks intersections with in-range values. TBR=reed@google.com BUG=630378 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166813006 Committed: https://skia.googlesource.com/skia/+/cdeff81bdb2e5cde422b6850634c5d3977fcbae9

Patch Set 1 #

Patch Set 2 : make opassert explicitly debug only #

Patch Set 3 : set test to skip asserts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -5 lines) Patch
M src/pathops/SkPathOpsTSect.h View 7 chunks +11 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166813006/40001
4 years, 5 months ago (2016-07-21 21:35:32 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 10:34:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/cdeff81bdb2e5cde422b6850634c5d3977fcbae9

Powered by Google App Engine
This is Rietveld 408576698