third_party/WebKit/Source/core/html/HTMLPlugInElement.h - Issue 2166813005: Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 2166813005: Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename PluginUnavailabilityReason to PluginAvailability Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

index 5459be0611818aa7313e2d5f5943d35dd268bec3..8b91487abf2673dc6bfe19e2419276590842194a 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

@@ -140,6 +140,10 @@ private:

mutable RefPtr<SharedPersistent<v8::Object>> m_pluginWrapper;

bool m_needsWidgetUpdate;

bool m_shouldPreferPlugInsForImages;

+ // Represents |layoutObject() && layoutObject()->isEmbeddedObject() &&

+ // !layoutEmbeddedItem().showsUnavailablePluginIndicator()|. We want to

+ // avoid to access |layoutObject()| in layoutObjectIsFocusable().

kochi 2016/07/21 05:04:23 nit: avoid accessing

tkent 2016/07/21 05:07:22 Done.

+ bool m_pluginIsAvailable = false;

// Normally the Widget is stored in HTMLFrameOwnerElement::m_widget.

// However, plugins can persist even when not rendered. In order to

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »