Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h

Issue 2166813005: Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h
index fc45dbb5914da3f3b4c28d4b89a04babe9a6b745..1ac55d0b2ca8dc7a9b9ef67ffb79639073c4047d 100644
--- a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.h
@@ -36,7 +36,9 @@ public:
LayoutEmbeddedObject(Element*);
~LayoutEmbeddedObject() override;
+ // TODO(tkent): Rename this to PluginAvailability.
kochi 2016/07/21 02:09:56 Why not now? Is this making this change too large?
tkent 2016/07/21 02:21:07 ok, will do.
enum PluginUnavailabilityReason {
+ PluginAvailable,
PluginMissing,
PluginBlockedByContentSecurityPolicy,
};
@@ -64,8 +66,7 @@ private:
CompositingReasons additionalCompositingReasons() const override;
- bool m_showsUnavailablePluginIndicator;
- PluginUnavailabilityReason m_pluginUnavailabilityReason;
+ PluginUnavailabilityReason m_pluginUnavailabilityReason = PluginAvailable;
String m_unavailablePluginReplacementText;
};

Powered by Google App Engine
This is Rietveld 408576698