Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 2166813005: Remove layoutObject() dependency from HTMLPlugInElement::layoutObjectIsFocusable(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004, 2006, 2007, 2008, 2009, 2012 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2004, 2006, 2007, 2008, 2009, 2012 Apple Inc. All rights reserv ed.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 bool allowedToLoadPlugin(const KURL&, const String& mimeType); 133 bool allowedToLoadPlugin(const KURL&, const String& mimeType);
134 // Perform checks based on the URL and MIME-type of the object to load. 134 // Perform checks based on the URL and MIME-type of the object to load.
135 bool allowedToLoadObject(const KURL&, const String& mimeType); 135 bool allowedToLoadObject(const KURL&, const String& mimeType);
136 bool wouldLoadAsNetscapePlugin(const String& url, const String& serviceType) ; 136 bool wouldLoadAsNetscapePlugin(const String& url, const String& serviceType) ;
137 137
138 void setPersistedPluginWidget(Widget*); 138 void setPersistedPluginWidget(Widget*);
139 139
140 mutable RefPtr<SharedPersistent<v8::Object>> m_pluginWrapper; 140 mutable RefPtr<SharedPersistent<v8::Object>> m_pluginWrapper;
141 bool m_needsWidgetUpdate; 141 bool m_needsWidgetUpdate;
142 bool m_shouldPreferPlugInsForImages; 142 bool m_shouldPreferPlugInsForImages;
143 // Represents |layoutObject() && layoutObject()->isEmbeddedObject() &&
144 // !layoutEmbeddedItem().showsUnavailablePluginIndicator()|. We want to
145 // avoid to access |layoutObject()| in layoutObjectIsFocusable().
146 bool m_pluginIsAvailable = false;
143 147
144 // Normally the Widget is stored in HTMLFrameOwnerElement::m_widget. 148 // Normally the Widget is stored in HTMLFrameOwnerElement::m_widget.
145 // However, plugins can persist even when not rendered. In order to 149 // However, plugins can persist even when not rendered. In order to
146 // prevent confusing code which may assume that widget() != null 150 // prevent confusing code which may assume that widget() != null
147 // means the frame is active, we save off m_widget here while 151 // means the frame is active, we save off m_widget here while
148 // the plugin is persisting but not being displayed. 152 // the plugin is persisting but not being displayed.
149 Member<Widget> m_persistedPluginWidget; 153 Member<Widget> m_persistedPluginWidget;
150 }; 154 };
151 155
152 inline bool isHTMLPlugInElement(const HTMLElement& element) 156 inline bool isHTMLPlugInElement(const HTMLElement& element)
153 { 157 {
154 return element.isPluginElement(); 158 return element.isPluginElement();
155 } 159 }
156 160
157 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLPlugInElement); 161 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLPlugInElement);
158 162
159 } // namespace blink 163 } // namespace blink
160 164
161 #endif // HTMLPlugInElement_h 165 #endif // HTMLPlugInElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698