Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2166813004: Let the command buffer service target directly depend on Skia in gyp. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let the command buffer service target directly depend on Skia in gyp. The class GLES2DecoderImpl::CALayerSharedState has a gfx::Transform member, which in turn has a SkMatrix44 member. In gyp, this means that the command buffer service target needs to depend on Skia. BUG=629899 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3f204686607e8d039d6599cdbcc1607d6d65c1c5 Cr-Commit-Position: refs/heads/master@{#406878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gpu/command_buffer_service.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
erikchen
piman: Please review.
4 years, 5 months ago (2016-07-21 00:20:47 UTC) #4
piman
lgtm
4 years, 5 months ago (2016-07-21 01:07:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166813004/1
4 years, 5 months ago (2016-07-21 16:18:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 16:57:08 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:00:06 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f204686607e8d039d6599cdbcc1607d6d65c1c5
Cr-Commit-Position: refs/heads/master@{#406878}

Powered by Google App Engine
This is Rietveld 408576698