Implement newly saved card bubble for realz and update generated card bubble to

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 267 matching lines @@
   DialogType dialog_type_;
 
   DISALLOW_COPY_AND_ASSIGN(TestAutofillDialogController);
 };
 
 class TestAutofillCreditCardBubbleController :
     public AutofillCreditCardBubbleController {
  public:
   explicit TestAutofillCreditCardBubbleController(
       content::WebContents* contents)
-      : AutofillCreditCardBubbleController(contents) {
+      : AutofillCreditCardBubbleController(contents),
+        new_card_bubbles_shown_(0) {
     contents->SetUserData(UserDataKey(), this);
     CHECK_EQ(contents->GetUserData(UserDataKey()), this);
   }
 
   virtual ~TestAutofillCreditCardBubbleController() {}
 
   MOCK_METHOD2(ShowAsGeneratedCardBubble,
                void(const base::string16& backing_card_name,
                     const base::string16& fronting_card_name));
-  MOCK_METHOD1(ShowAsNewCardSavedBubble,
-               void(const base::string16& newly_saved_card_name));
+
+  int new_card_bubbles_shown() const { return new_card_bubbles_shown_; }
+  const CreditCard* new_card() const { return new_card_.get(); }
 
  protected:
+  virtual void ShowAsNewCardSavedBubble(
+      scoped_ptr<CreditCard> new_card,
+      scoped_ptr<AutofillProfile> billing_profile) OVERRIDE {
+    ++new_card_bubbles_shown_;
+    new_card_ = new_card.Pass();
+    // At the moment there's no keep |billing_profile|.
+  }
+
   virtual base::WeakPtr<AutofillCreditCardBubble> CreateBubble() OVERRIDE {
     return TestAutofillCreditCardBubble::Create(GetWeakPtr());
   }
 
   virtual bool CanShow() const OVERRIDE {
     return true;
   }
 
  private:
+  // The number of new card saved bubble shown through this class.
+  int new_card_bubbles_shown_;
+
+  // The last credit card and billing info shown in a new card bubble.
+  scoped_ptr<CreditCard> new_card_;
+
   DISALLOW_COPY_AND_ASSIGN(TestAutofillCreditCardBubbleController);
 };
 
 class AutofillDialogControllerTest : public ChromeRenderViewHostTestHarness {
  protected:
   AutofillDialogControllerTest(): form_structure_(NULL) {}
 
   // testing::Test implementation:
   virtual void SetUp() OVERRIDE {
     ChromeRenderViewHostTestHarness::SetUp();
@@ skipping 1962 matching lines @@
   EXPECT_EQ(AUTOCHECKOUT_STEP_UNSTARTED,
             controller()->CurrentAutocheckoutSteps()[2].status());
 
   controller()->ViewClosed();
   EXPECT_FALSE(ReadSetVisuallyDeemphasizedIpc());
 }
 
 
 TEST_F(AutofillDialogControllerTest, NewCardBubbleShown) {
   EXPECT_CALL(*test_bubble_controller(),
-              ShowAsNewCardSavedBubble(ASCIIToUTF16("Visa - 1111"))).Times(1);
-  EXPECT_CALL(*test_bubble_controller(),
               ShowAsGeneratedCardBubble(_, _)).Times(0);
 
   SwitchToAutofill();
   FillCreditCardInputs();
   controller()->OnAccept();
   controller()->ViewClosed();
+
+  EXPECT_EQ(1, test_bubble_controller()->new_card_bubbles_shown());
+  EXPECT_EQ(ASCIIToUTF16("Visa - 4111"),
+            test_bubble_controller()->new_card()->TypeAndLastFourDigits());
 }
 
 TEST_F(AutofillDialogControllerTest, GeneratedCardBubbleShown) {
   EXPECT_CALL(*test_bubble_controller(),
               ShowAsGeneratedCardBubble(_, _)).Times(1);
-  EXPECT_CALL(*test_bubble_controller(), ShowAsNewCardSavedBubble(_)).Times(0);
 
   SubmitWithWalletItems(CompleteAndValidWalletItems());
   controller()->OnDidGetFullWallet(wallet::GetTestFullWallet());
   controller()->ViewClosed();
+
+  EXPECT_EQ(0, test_bubble_controller()->new_card_bubbles_shown());
 }
 
 TEST_F(AutofillDialogControllerTest, ReloadWalletItemsOnActivation) {
   // Switch into Wallet mode and initialize some Wallet data.
   SwitchToWallet();
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddInstrument(wallet::GetTestNonDefaultMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestNonDefaultShippingAddress());
@@ skipping 57 matching lines @@
   controller()->OnDidGetWalletItems(wallet::GetTestWalletItems());
 
   EXPECT_FALSE(controller()->MenuModelForSection(SECTION_CC_BILLING));
   EXPECT_EQ(
       3, controller()->MenuModelForSection(SECTION_SHIPPING)->GetItemCount());
 }
 
 TEST_F(AutofillDialogControllerTest, GeneratedCardBubbleNotShown) {
   EXPECT_CALL(*test_bubble_controller(),
               ShowAsGeneratedCardBubble(_, _)).Times(0);
-  EXPECT_CALL(*test_bubble_controller(), ShowAsNewCardSavedBubble(_)).Times(0);
 
   SubmitWithWalletItems(CompleteAndValidWalletItems());
   controller()->set_dialog_type(DIALOG_TYPE_AUTOCHECKOUT);
   controller()->OnDidGetFullWallet(wallet::GetTestFullWallet());
   controller()->OnAutocheckoutError();
   controller()->ViewClosed();
+
+  EXPECT_EQ(0, test_bubble_controller()->new_card_bubbles_shown());
 }
 
 }  // namespace autofill