Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2166793002: [wasm] Use a C wrapper function to calculate F64Pow. (Closed)

Created:
4 years, 5 months ago by ahaas
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use a C wrapper function to calculate F64Pow. This CL more or less reverts commit https://codereview.chromium.org/2107733002/ The use of the MathPow code stub that was introduced by that commit caused problems on arm64, and the MathPow code stub was also an obstacle in the implementation of parallel code generation. In addition this CL turns on the mjsunit/wasm/embenchen tests for arm64 which were turned off because of problems with MathPow on arm64. R=titzer@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/6627d81c68a1add48f530ca6a654f13c158734f7 Cr-Commit-Position: refs/heads/master@{#37911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/wasm-external-refs.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/wasm/wasm-external-refs.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-calls-to-external-references.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
ahaas
4 years, 5 months ago (2016-07-20 13:31:21 UTC) #1
titzer
On 2016/07/20 13:31:21, ahaas wrote: lgtm
4 years, 5 months ago (2016-07-20 14:19:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166793002/1
4 years, 5 months ago (2016-07-20 14:21:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 14:24:54 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6627d81c68a1add48f530ca6a654f13c158734f7 Cr-Commit-Position: refs/heads/master@{#37911}
4 years, 5 months ago (2016-07-20 14:27:12 UTC) #11
Benedikt Meurer
4 years, 5 months ago (2016-07-20 17:24:54 UTC) #13
Message was sent while issue was closed.
Nice, thanks.

Powered by Google App Engine
This is Rietveld 408576698