Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2166743005: [tools/perf] Rename mobile_facebook_login to facebook_login (Closed)

Created:
4 years, 5 months ago by nednguyen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Rename mobile_facebook_login to facebook_login This CL also renames mobile_facebook_login.LoginAccount to facebook_login.LoginWithMobileSite. Motivation: later we will add a login method for facebook desktop, hence generalize this module to support both. BUG=589726 Committed: https://crrev.com/589d0860b313ce427c759822b559e308dca73e79 Cr-Commit-Position: refs/heads/master@{#407122}

Patch Set 1 #

Patch Set 2 : Upload renamed file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -38 lines) Patch
A + tools/perf/page_sets/login_helpers/facebook_login.py View 1 1 chunk +1 line, -1 line 0 comments Download
D tools/perf/page_sets/login_helpers/mobile_facebook_login.py View 1 chunk +0 lines, -35 lines 0 comments Download
M tools/perf/page_sets/mobile_facebook_page.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
nednguyen
4 years, 5 months ago (2016-07-21 17:54:53 UTC) #2
petrcermak
I think you forgot to include the renamed file ;-) Also s/This CL also rename/This ...
4 years, 5 months ago (2016-07-21 18:48:15 UTC) #3
nednguyen
On 2016/07/21 18:48:15, petrcermak wrote: > I think you forgot to include the renamed file ...
4 years, 5 months ago (2016-07-22 00:30:55 UTC) #5
petrcermak
lgtm
4 years, 5 months ago (2016-07-22 09:42:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166743005/20001
4 years, 5 months ago (2016-07-22 09:43:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 10:11:12 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 10:15:06 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/589d0860b313ce427c759822b559e308dca73e79
Cr-Commit-Position: refs/heads/master@{#407122}

Powered by Google App Engine
This is Rietveld 408576698