Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2166733002: MD History: Fix appearance of 'Other forms of browsing history' link (Closed)

Created:
4 years, 5 months ago by tsergeant
Modified:
4 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix appearance of 'Other forms of browsing history' link crrev.com/406488 added extra styling for <a> tags in the side bar. This also changed the appearance of the history.google.com link in the sidebar footer. This CL changes the selectors so that these styles only apply to the top-level links, as intended. BUG=609502 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7e173b7e91a15b8414f12a8320675f0cc0ecbe8a Cr-Commit-Position: refs/heads/master@{#406772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/md_history/side_bar.html View 3 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
tsergeant
4 years, 5 months ago (2016-07-20 05:51:43 UTC) #6
calamity
lgtm
4 years, 5 months ago (2016-07-21 05:20:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166733002/1
4 years, 5 months ago (2016-07-21 05:24:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 05:28:15 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 05:30:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e173b7e91a15b8414f12a8320675f0cc0ecbe8a
Cr-Commit-Position: refs/heads/master@{#406772}

Powered by Google App Engine
This is Rietveld 408576698