Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 216673006: Revert 260177 "By keeping track of transfer buffer usage (both s..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc
===================================================================
--- trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc (revision 260192)
+++ trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc (working copy)
@@ -15,12 +15,10 @@
#include "base/at_exit.h"
#include "base/bind.h"
-#include "base/callback_helpers.h"
#include "base/command_line.h"
#include "base/debug/trace_event.h"
#include "base/debug/trace_event_synthetic_delay.h"
#include "base/memory/scoped_ptr.h"
-#include "base/numerics/safe_math.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "build/build_config.h"
@@ -520,29 +518,6 @@
scoped_ptr<gfx::GLFence> fence;
};
-class AsyncUploadTokenCompletionObserver
- : public AsyncPixelTransferCompletionObserver {
- public:
- explicit AsyncUploadTokenCompletionObserver(uint32 async_upload_token)
- : async_upload_token_(async_upload_token) {
- }
-
- virtual void DidComplete(const AsyncMemoryParams& mem_params) OVERRIDE {
- DCHECK(mem_params.buffer());
- void* data = mem_params.GetDataAddress();
- AsyncUploadSync* sync = static_cast<AsyncUploadSync*>(data);
- sync->SetAsyncUploadToken(async_upload_token_);
- }
-
- private:
- virtual ~AsyncUploadTokenCompletionObserver() {
- }
-
- uint32 async_upload_token_;
-
- DISALLOW_COPY_AND_ASSIGN(AsyncUploadTokenCompletionObserver);
-};
-
// } // anonymous namespace.
bool GLES2Decoder::GetServiceTextureId(uint32 client_texture_id,
@@ -738,13 +713,6 @@
bool GenVertexArraysOESHelper(GLsizei n, const GLuint* client_ids);
void DeleteVertexArraysOESHelper(GLsizei n, const GLuint* client_ids);
- // Helper for async upload token completion notification callback.
- base::Closure AsyncUploadTokenCompletionClosure(uint32 async_upload_token,
- uint32 sync_data_shm_id,
- uint32 sync_data_shm_offset);
-
-
-
// Workarounds
void OnFboChanged() const;
void OnUseFramebuffer() const;
@@ -10387,29 +10355,6 @@
return true;
}
-base::Closure GLES2DecoderImpl::AsyncUploadTokenCompletionClosure(
- uint32 async_upload_token,
- uint32 sync_data_shm_id,
- uint32 sync_data_shm_offset) {
- scoped_refptr<gpu::Buffer> buffer = GetSharedMemoryBuffer(sync_data_shm_id);
- if (!buffer || !buffer->GetDataAddress(sync_data_shm_offset,
- sizeof(AsyncUploadSync)))
- return base::Closure();
-
- AsyncMemoryParams mem_params(buffer,
- sync_data_shm_offset,
- sizeof(AsyncUploadSync));
-
- scoped_refptr<AsyncUploadTokenCompletionObserver> observer(
- new AsyncUploadTokenCompletionObserver(async_upload_token));
-
- return base::Bind(
- &AsyncPixelTransferManager::AsyncNotifyCompletion,
- base::Unretained(GetAsyncPixelTransferManager()),
- mem_params,
- observer);
-}
-
error::Error GLES2DecoderImpl::HandleAsyncTexImage2DCHROMIUM(
uint32 immediate_data_size, const cmds::AsyncTexImage2DCHROMIUM& c) {
TRACE_EVENT0("gpu", "GLES2DecoderImpl::HandleAsyncTexImage2DCHROMIUM");
@@ -10426,22 +10371,7 @@
uint32 pixels_shm_id = static_cast<uint32>(c.pixels_shm_id);
uint32 pixels_shm_offset = static_cast<uint32>(c.pixels_shm_offset);
uint32 pixels_size;
- uint32 async_upload_token = static_cast<uint32>(c.async_upload_token);
- uint32 sync_data_shm_id = static_cast<uint32>(c.sync_data_shm_id);
- uint32 sync_data_shm_offset = static_cast<uint32>(c.sync_data_shm_offset);
- base::ScopedClosureRunner scoped_completion_callback;
- if (async_upload_token) {
- base::Closure completion_closure =
- AsyncUploadTokenCompletionClosure(async_upload_token,
- sync_data_shm_id,
- sync_data_shm_offset);
- if (completion_closure.is_null())
- return error::kInvalidArguments;
-
- scoped_completion_callback.Reset(completion_closure);
- }
-
// TODO(epenner): Move this and copies of this memory validation
// into ValidateTexImage2D step.
if (!GLES2Util::ComputeImageDataSizes(
@@ -10527,22 +10457,7 @@
GLsizei height = static_cast<GLsizei>(c.height);
GLenum format = static_cast<GLenum>(c.format);
GLenum type = static_cast<GLenum>(c.type);
- uint32 async_upload_token = static_cast<uint32>(c.async_upload_token);
- uint32 sync_data_shm_id = static_cast<uint32>(c.sync_data_shm_id);
- uint32 sync_data_shm_offset = static_cast<uint32>(c.sync_data_shm_offset);
- base::ScopedClosureRunner scoped_completion_callback;
- if (async_upload_token) {
- base::Closure completion_closure =
- AsyncUploadTokenCompletionClosure(async_upload_token,
- sync_data_shm_id,
- sync_data_shm_offset);
- if (completion_closure.is_null())
- return error::kInvalidArguments;
-
- scoped_completion_callback.Reset(completion_closure);
- }
-
// TODO(epenner): Move this and copies of this memory validation
// into ValidateTexSubImage2D step.
uint32 data_size;
@@ -10644,15 +10559,6 @@
return error::kNoError;
}
-error::Error GLES2DecoderImpl::HandleWaitAllAsyncTexImage2DCHROMIUM(
- uint32 immediate_data_size, const cmds::WaitAllAsyncTexImage2DCHROMIUM& c) {
- TRACE_EVENT0("gpu", "GLES2DecoderImpl::HandleWaitAsyncTexImage2DCHROMIUM");
-
- GetAsyncPixelTransferManager()->WaitAllAsyncTexImage2D();
- ProcessFinishedAsyncTransfers();
- return error::kNoError;
-}
-
void GLES2DecoderImpl::OnTextureRefDetachedFromFramebuffer(
TextureRef* texture_ref) {
Texture* texture = texture_ref->texture();

Powered by Google App Engine
This is Rietveld 408576698