Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: trunk/src/gpu/command_buffer/client/gles2_implementation.h

Issue 216673006: Revert 260177 "By keeping track of transfer buffer usage (both s..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/gpu/command_buffer/client/gles2_implementation.h
===================================================================
--- trunk/src/gpu/command_buffer/client/gles2_implementation.h (revision 260192)
+++ trunk/src/gpu/command_buffer/client/gles2_implementation.h (working copy)
@@ -596,38 +596,6 @@
void OnSwapBuffersComplete();
- // Remove the transfer buffer from the buffer tracker. For buffers used
- // asynchronously the memory is free:ed if the upload has completed. For
- // other buffers, the memory is either free:ed immediately or free:ed pending
- // a token.
- void RemoveTransferBuffer(BufferTracker::Buffer* buffer);
-
- // Returns true if the async upload token has passed.
- //
- // NOTE: This will detect wrapped async tokens by checking if the most
- // significant bit of async token to check is 1 but the last read is 0, i.e.
- // the uint32 wrapped.
- bool HasAsyncUploadTokenPassed(uint32 token) const {
- return async_upload_sync_->HasAsyncUploadTokenPassed(token);
- }
-
- // Get the next async upload token.
- uint32 NextAsyncUploadToken();
-
- // Ensure that the shared memory used for synchronizing async upload tokens
- // has been mapped.
- //
- // Returns false on error, true on success.
- bool EnsureAsyncUploadSync();
-
- // Checks the last read asynchronously upload token and frees any unmanaged
- // transfer buffer that has its async token passed.
- void PollAsyncUploads();
-
- // Free every async upload buffer. If some async upload buffer is still in use
- // wait for them to finish before freeing.
- void FreeAllAsyncUploadBuffers();
-
bool GetBoundPixelTransferBuffer(
GLenum target, const char* function_name, GLuint* buffer_id);
BufferTracker::Buffer* GetBoundPixelUnpackTransferBufferIfValid(
@@ -700,18 +668,6 @@
GLuint bound_pixel_pack_transfer_buffer_id_;
GLuint bound_pixel_unpack_transfer_buffer_id_;
- // The current asynchronous pixel buffer upload token.
- uint32 async_upload_token_;
-
- // The shared memory used for synchronizing asynchronous upload tokens.
- AsyncUploadSync* async_upload_sync_;
- int32 async_upload_sync_shm_id_;
- unsigned int async_upload_sync_shm_offset_;
-
- // Unmanaged pixel transfer buffer memory pending asynchronous upload token.
- typedef std::list<std::pair<void*, uint32> > DetachedAsyncUploadMemoryList;
- DetachedAsyncUploadMemoryList detached_async_upload_memory_;
-
// Client side management for vertex array objects. Needed to correctly
// track client side arrays.
scoped_ptr<VertexArrayObjectManager> vertex_array_object_manager_;

Powered by Google App Engine
This is Rietveld 408576698