Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: trunk/src/gpu/command_buffer/client/fenced_allocator_test.cc

Issue 216673006: Revert 260177 "By keeping track of transfer buffer usage (both s..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/gpu/command_buffer/client/fenced_allocator_test.cc
===================================================================
--- trunk/src/gpu/command_buffer/client/fenced_allocator_test.cc (revision 260192)
+++ trunk/src/gpu/command_buffer/client/fenced_allocator_test.cc (working copy)
@@ -29,7 +29,6 @@
using testing::Sequence;
using testing::DoAll;
using testing::Invoke;
-using testing::InvokeWithoutArgs;
using testing::_;
class BaseFencedAllocatorTest : public testing::Test {
@@ -89,11 +88,6 @@
const unsigned int BaseFencedAllocatorTest::kBufferSize;
#endif
-namespace {
-void EmptyPoll() {
-}
-}
-
// Test fixture for FencedAllocator test - Creates a FencedAllocator, using a
// CommandBufferHelper with a mock AsyncAPIInterface for its interface (calling
// it directly, not through the RPC mechanism), making sure Noops are ignored
@@ -102,9 +96,7 @@
protected:
virtual void SetUp() {
BaseFencedAllocatorTest::SetUp();
- allocator_.reset(new FencedAllocator(kBufferSize,
- helper_.get(),
- base::Bind(&EmptyPoll)));
+ allocator_.reset(new FencedAllocator(kBufferSize, helper_.get()));
}
virtual void TearDown() {
@@ -399,63 +391,6 @@
EXPECT_EQ(kBufferSize, allocator_->GetLargestFreeSize());
}
-class FencedAllocatorPollTest : public BaseFencedAllocatorTest {
- public:
- static const unsigned int kAllocSize = 128;
-
- MOCK_METHOD0(MockedPoll, void());
-
- protected:
- virtual void TearDown() {
- // If the GpuScheduler posts any tasks, this forces them to run.
- base::MessageLoop::current()->RunUntilIdle();
-
- BaseFencedAllocatorTest::TearDown();
- }
-};
-
-TEST_F(FencedAllocatorPollTest, TestPoll) {
- scoped_ptr<FencedAllocator> allocator(
- new FencedAllocator(kBufferSize,
- helper_.get(),
- base::Bind(&FencedAllocatorPollTest::MockedPoll,
- base::Unretained(this))));
-
- FencedAllocator::Offset mem1 = allocator->Alloc(kAllocSize);
- FencedAllocator::Offset mem2 = allocator->Alloc(kAllocSize);
- EXPECT_NE(mem1, FencedAllocator::kInvalidOffset);
- EXPECT_NE(mem2, FencedAllocator::kInvalidOffset);
- EXPECT_TRUE(allocator->CheckConsistency());
- EXPECT_EQ(allocator->bytes_in_use(), kAllocSize * 2);
-
- // Check that no-op Poll doesn't affect the state.
- EXPECT_CALL(*this, MockedPoll()).RetiresOnSaturation();
- allocator->FreeUnused();
- EXPECT_TRUE(allocator->CheckConsistency());
- EXPECT_EQ(allocator->bytes_in_use(), kAllocSize * 2);
-
- // Check that freeing in Poll works.
- base::Closure free_mem1_closure =
- base::Bind(&FencedAllocator::Free,
- base::Unretained(allocator.get()),
- mem1);
- EXPECT_CALL(*this, MockedPoll())
- .WillOnce(InvokeWithoutArgs(&free_mem1_closure, &base::Closure::Run))
- .RetiresOnSaturation();
- allocator->FreeUnused();
- EXPECT_TRUE(allocator->CheckConsistency());
- EXPECT_EQ(allocator->bytes_in_use(), kAllocSize * 1);
-
- // Check that freeing still works.
- EXPECT_CALL(*this, MockedPoll()).RetiresOnSaturation();
- allocator->Free(mem2);
- allocator->FreeUnused();
- EXPECT_TRUE(allocator->CheckConsistency());
- EXPECT_EQ(allocator->bytes_in_use(), 0u);
-
- allocator.reset();
-}
-
// Test fixture for FencedAllocatorWrapper test - Creates a
// FencedAllocatorWrapper, using a CommandBufferHelper with a mock
// AsyncAPIInterface for its interface (calling it directly, not through the
@@ -471,9 +406,7 @@
// something.
buffer_.reset(static_cast<char*>(base::AlignedAlloc(
kBufferSize, kAllocAlignment)));
- allocator_.reset(new FencedAllocatorWrapper(kBufferSize,
- helper_.get(),
- base::Bind(&EmptyPoll),
+ allocator_.reset(new FencedAllocatorWrapper(kBufferSize, helper_.get(),
buffer_.get()));
}
« no previous file with comments | « trunk/src/gpu/command_buffer/client/fenced_allocator.cc ('k') | trunk/src/gpu/command_buffer/client/gles2_c_lib_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698