Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: content/browser/media/capture/image_capture_impl.cc

Issue 2166713002: ImageCapture: replace Mojo String/Array with stl/wtf string/vector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot media/.../mojo_bindings.gyp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/capture/image_capture_impl.cc
diff --git a/content/browser/media/capture/image_capture_impl.cc b/content/browser/media/capture/image_capture_impl.cc
index 23da723eae8c78bb4712bab3a4267c42f9aad6f5..9941b7b4decdd3e8a8db3959b6cd72fad3d624d6 100644
--- a/content/browser/media/capture/image_capture_impl.cc
+++ b/content/browser/media/capture/image_capture_impl.cc
@@ -51,20 +51,23 @@ void RunFailedSetOptionsCallback(
void RunTakePhotoCallbackOnUIThread(
const ImageCaptureImpl::TakePhotoCallback& callback,
- mojo::String mime_type,
- mojo::Array<uint8_t> data) {
+ const std::string& mime_type,
+ const std::vector<uint8_t>& data) {
+ // TODO(mcasas): Use a mojo typemapping instead of const_cast to avoid copying
+ // |data|, https://crbug.com/630040.
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
- base::Bind(callback, mime_type, base::Passed(std::move(data))));
+ base::Bind(callback, mime_type,
+ base::Passed(const_cast<std::vector<uint8_t>*>(&data))));
}
void RunFailedTakePhotoCallback(const ImageCaptureImpl::TakePhotoCallback& cb) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- cb.Run("", mojo::Array<uint8_t>());
+ cb.Run("", std::vector<uint8_t>());
}
void GetCapabilitiesOnIOThread(
- const mojo::String& source_id,
+ const std::string& source_id,
MediaStreamManager* media_stream_manager,
media::ScopedResultCallback<ImageCaptureImpl::GetCapabilitiesCallback>
callback) {
@@ -80,7 +83,7 @@ void GetCapabilitiesOnIOThread(
}
void SetOptionsOnIOThread(
- const mojo::String& source_id,
+ const std::string& source_id,
MediaStreamManager* media_stream_manager,
media::mojom::PhotoSettingsPtr settings,
media::ScopedResultCallback<ImageCaptureImpl::SetOptionsCallback>
@@ -97,7 +100,7 @@ void SetOptionsOnIOThread(
}
void TakePhotoOnIOThread(
- const mojo::String& source_id,
+ const std::string& source_id,
MediaStreamManager* media_stream_manager,
media::ScopedResultCallback<ImageCaptureImpl::TakePhotoCallback> callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
@@ -123,7 +126,7 @@ void ImageCaptureImpl::Create(
ImageCaptureImpl::~ImageCaptureImpl() {}
void ImageCaptureImpl::GetCapabilities(
- const mojo::String& source_id,
+ const std::string& source_id,
const GetCapabilitiesCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -138,7 +141,7 @@ void ImageCaptureImpl::GetCapabilities(
base::Passed(&scoped_callback)));
}
-void ImageCaptureImpl::SetOptions(const mojo::String& source_id,
+void ImageCaptureImpl::SetOptions(const std::string& source_id,
media::mojom::PhotoSettingsPtr settings,
const SetOptionsCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -154,7 +157,7 @@ void ImageCaptureImpl::SetOptions(const mojo::String& source_id,
base::Passed(&settings), base::Passed(&scoped_callback)));
}
-void ImageCaptureImpl::TakePhoto(const mojo::String& source_id,
+void ImageCaptureImpl::TakePhoto(const std::string& source_id,
const TakePhotoCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
« no previous file with comments | « content/browser/media/capture/image_capture_impl.h ('k') | media/capture/video/android/video_capture_device_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698