Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2166703002: X87: [builtins] Introduce a builtin for Abort(). (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce a builtin for Abort(). port 9be015a254cfff871c56cd129523a729637e9158 (r37854) original commit message: Calling Runtime::kAbort through a builtin instead of the c-entry stub will allow to generate the call in a background thread, because a builtin provides its own handle, whereas a code stub does not. @v8-mips-ports: Could you take a special look at the padding that is done in MacroAssembler::Abort()? BUG= Committed: https://crrev.com/f910bfeb3d4f12529164745c20df484c6e4b8e9f Cr-Commit-Position: refs/heads/master@{#37880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/builtins/x87/builtins-x87.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-20 02:34:34 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-20 03:31:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166703002/1
4 years, 5 months ago (2016-07-20 03:32:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 03:54:05 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 03:56:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f910bfeb3d4f12529164745c20df484c6e4b8e9f
Cr-Commit-Position: refs/heads/master@{#37880}

Powered by Google App Engine
This is Rietveld 408576698