components/spellcheck.gypi - Issue 2166683003: Componentize spellcheck [1]: create component and move switches there.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/spellcheck.gypi

Issue 2166683003: Componentize spellcheck [1]: create component and move switches there. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update components/OWNERS Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2016 The Chromium Authors. All rights reserved.
	Peter Beverloo 2016/07/22 12:45:24 nit: no (c) nit: no (c) timvolodine 2016/07/22 17:25:35 Done. Show quoted text On 2016/07/22 12:45:24, Peter Beverloo wrote: > nit: no (c) Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # GYP version: components:spellcheck.gypi:spellcheck_common
	Peter Beverloo 2016/07/22 12:45:24 I don't understand this line- the GN version is re I don't understand this line- the GN version is referred to on line 9, so I think you can just remove it timvolodine 2016/07/22 17:25:35 removed, done. Show quoted text On 2016/07/22 12:45:24, Peter Beverloo wrote: > I don't understand this line- the GN version is referred to on line 9, so I > think you can just remove it removed, done.
	6 {

	7 'targets': [

	8 {

	9 # GN version: //components/spellcheck/common

	10 'target_name': 'spellcheck_common',

	11 'type': 'static_library',

	12 'include_dirs': [

	13 '..',

	14 ],

	15 'sources': [

	16 'spellcheck/common/spellcheck_switches.cc',

	17 'spellcheck/common/spellcheck_switches.h',

	18 ],

	19 },

	20 ],

	21 }

OLD	NEW

« no previous file with comments | « components/components.gyp ('k') | components/spellcheck/OWNERS » ('j') | components/spellcheck/OWNERS » ('J')