Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2166683003: Componentize spellcheck [1]: create component and move switches there. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + --no-find-copies Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 #include "components/network_session_configurator/switches.h" 46 #include "components/network_session_configurator/switches.h"
47 #include "components/ntp_snippets/ntp_snippets_constants.h" 47 #include "components/ntp_snippets/ntp_snippets_constants.h"
48 #include "components/ntp_tiles/switches.h" 48 #include "components/ntp_tiles/switches.h"
49 #include "components/offline_pages/offline_page_feature.h" 49 #include "components/offline_pages/offline_page_feature.h"
50 #include "components/omnibox/browser/omnibox_switches.h" 50 #include "components/omnibox/browser/omnibox_switches.h"
51 #include "components/password_manager/core/common/password_manager_features.h" 51 #include "components/password_manager/core/common/password_manager_features.h"
52 #include "components/proximity_auth/switches.h" 52 #include "components/proximity_auth/switches.h"
53 #include "components/search/search_switches.h" 53 #include "components/search/search_switches.h"
54 #include "components/security_state/switches.h" 54 #include "components/security_state/switches.h"
55 #include "components/signin/core/common/signin_switches.h" 55 #include "components/signin/core/common/signin_switches.h"
56 #include "components/spellcheck/common/spellcheck_switches.h"
56 #include "components/ssl_config/ssl_config_switches.h" 57 #include "components/ssl_config/ssl_config_switches.h"
57 #include "components/sync_driver/sync_driver_switches.h" 58 #include "components/sync_driver/sync_driver_switches.h"
58 #include "components/tracing/common/tracing_switches.h" 59 #include "components/tracing/common/tracing_switches.h"
59 #include "components/translate/core/browser/translate_prefs.h" 60 #include "components/translate/core/browser/translate_prefs.h"
60 #include "components/version_info/version_info.h" 61 #include "components/version_info/version_info.h"
61 #include "content/public/browser/user_metrics.h" 62 #include "content/public/browser/user_metrics.h"
62 #include "content/public/common/content_features.h" 63 #include "content/public/common/content_features.h"
63 #include "content/public/common/content_switches.h" 64 #include "content/public/common/content_switches.h"
64 #include "content/public/common/feature_h264_with_openh264_ffmpeg.h" 65 #include "content/public/common/feature_h264_with_openh264_ffmpeg.h"
65 #include "content/public/common/features.h" 66 #include "content/public/common/features.h"
(...skipping 757 matching lines...) Expand 10 before | Expand all | Expand 10 after
823 {"enable-devtools-experiments", IDS_FLAGS_DEVTOOLS_EXPERIMENTS_NAME, 824 {"enable-devtools-experiments", IDS_FLAGS_DEVTOOLS_EXPERIMENTS_NAME,
824 IDS_FLAGS_DEVTOOLS_EXPERIMENTS_DESCRIPTION, kOsDesktop, 825 IDS_FLAGS_DEVTOOLS_EXPERIMENTS_DESCRIPTION, kOsDesktop,
825 SINGLE_VALUE_TYPE(switches::kEnableDevToolsExperiments)}, 826 SINGLE_VALUE_TYPE(switches::kEnableDevToolsExperiments)},
826 {"silent-debugger-extension-api", 827 {"silent-debugger-extension-api",
827 IDS_FLAGS_SILENT_DEBUGGER_EXTENSION_API_NAME, 828 IDS_FLAGS_SILENT_DEBUGGER_EXTENSION_API_NAME,
828 IDS_FLAGS_SILENT_DEBUGGER_EXTENSION_API_DESCRIPTION, kOsDesktop, 829 IDS_FLAGS_SILENT_DEBUGGER_EXTENSION_API_DESCRIPTION, kOsDesktop,
829 SINGLE_VALUE_TYPE(switches::kSilentDebuggerExtensionAPI)}, 830 SINGLE_VALUE_TYPE(switches::kSilentDebuggerExtensionAPI)},
830 #if defined(ENABLE_SPELLCHECK) && defined(OS_ANDROID) 831 #if defined(ENABLE_SPELLCHECK) && defined(OS_ANDROID)
831 {"enable-android-spellchecker", IDS_OPTIONS_ENABLE_SPELLCHECK, 832 {"enable-android-spellchecker", IDS_OPTIONS_ENABLE_SPELLCHECK,
832 IDS_OPTIONS_ENABLE_ANDROID_SPELLCHECKER_DESCRIPTION, kOsAndroid, 833 IDS_OPTIONS_ENABLE_ANDROID_SPELLCHECKER_DESCRIPTION, kOsAndroid,
833 SINGLE_VALUE_TYPE(switches::kEnableAndroidSpellChecker)}, 834 SINGLE_VALUE_TYPE(spellcheck::switches::kEnableAndroidSpellChecker)},
834 #endif 835 #endif
835 {"enable-scroll-prediction", IDS_FLAGS_SCROLL_PREDICTION_NAME, 836 {"enable-scroll-prediction", IDS_FLAGS_SCROLL_PREDICTION_NAME,
836 IDS_FLAGS_SCROLL_PREDICTION_DESCRIPTION, kOsDesktop, 837 IDS_FLAGS_SCROLL_PREDICTION_DESCRIPTION, kOsDesktop,
837 SINGLE_VALUE_TYPE(switches::kEnableScrollPrediction)}, 838 SINGLE_VALUE_TYPE(switches::kEnableScrollPrediction)},
838 {"top-chrome-md", IDS_FLAGS_TOP_CHROME_MD, 839 {"top-chrome-md", IDS_FLAGS_TOP_CHROME_MD,
839 IDS_FLAGS_TOP_CHROME_MD_DESCRIPTION, kOsDesktop, 840 IDS_FLAGS_TOP_CHROME_MD_DESCRIPTION, kOsDesktop,
840 MULTI_VALUE_TYPE(kTopChromeMaterialDesignChoices)}, 841 MULTI_VALUE_TYPE(kTopChromeMaterialDesignChoices)},
841 {"secondary-ui-md", IDS_FLAGS_SECONDARY_UI_MD, 842 {"secondary-ui-md", IDS_FLAGS_SECONDARY_UI_MD,
842 IDS_FLAGS_SECONDARY_UI_MD_DESCRIPTION, kOsDesktop, 843 IDS_FLAGS_SECONDARY_UI_MD_DESCRIPTION, kOsDesktop,
843 SINGLE_VALUE_TYPE(switches::kExtendMdToSecondaryUi)}, 844 SINGLE_VALUE_TYPE(switches::kExtendMdToSecondaryUi)},
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
1213 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME, 1214 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_NAME,
1214 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION, 1215 IDS_FLAGS_HIDE_INACTIVE_STACKED_TAB_CLOSE_BUTTONS_DESCRIPTION,
1215 kOsCrOS | kOsWin | kOsLinux, 1216 kOsCrOS | kOsWin | kOsLinux,
1216 SINGLE_DISABLE_VALUE_TYPE( 1217 SINGLE_DISABLE_VALUE_TYPE(
1217 switches::kDisableHideInactiveStackedTabCloseButtons)}, 1218 switches::kDisableHideInactiveStackedTabCloseButtons)},
1218 #endif 1219 #endif
1219 #if defined(ENABLE_SPELLCHECK) 1220 #if defined(ENABLE_SPELLCHECK)
1220 {"enable-spelling-feedback-field-trial", 1221 {"enable-spelling-feedback-field-trial",
1221 IDS_FLAGS_SPELLING_FEEDBACK_FIELD_TRIAL_NAME, 1222 IDS_FLAGS_SPELLING_FEEDBACK_FIELD_TRIAL_NAME,
1222 IDS_FLAGS_SPELLING_FEEDBACK_FIELD_TRIAL_DESCRIPTION, kOsAll, 1223 IDS_FLAGS_SPELLING_FEEDBACK_FIELD_TRIAL_DESCRIPTION, kOsAll,
1223 SINGLE_VALUE_TYPE(switches::kEnableSpellingFeedbackFieldTrial)}, 1224 SINGLE_VALUE_TYPE(
1225 spellcheck::switches::kEnableSpellingFeedbackFieldTrial)},
1224 #endif 1226 #endif
1225 {"enable-webgl-draft-extensions", IDS_FLAGS_WEBGL_DRAFT_EXTENSIONS_NAME, 1227 {"enable-webgl-draft-extensions", IDS_FLAGS_WEBGL_DRAFT_EXTENSIONS_NAME,
1226 IDS_FLAGS_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION, kOsAll, 1228 IDS_FLAGS_WEBGL_DRAFT_EXTENSIONS_DESCRIPTION, kOsAll,
1227 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions)}, 1229 SINGLE_VALUE_TYPE(switches::kEnableWebGLDraftExtensions)},
1228 {"enable-new-profile-management", IDS_FLAGS_NEW_PROFILE_MANAGEMENT_NAME, 1230 {"enable-new-profile-management", IDS_FLAGS_NEW_PROFILE_MANAGEMENT_NAME,
1229 IDS_FLAGS_NEW_PROFILE_MANAGEMENT_DESCRIPTION, kOsAll, 1231 IDS_FLAGS_NEW_PROFILE_MANAGEMENT_DESCRIPTION, kOsAll,
1230 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableNewProfileManagement, 1232 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableNewProfileManagement,
1231 switches::kDisableNewProfileManagement)}, 1233 switches::kDisableNewProfileManagement)},
1232 {"enable-account-consistency", IDS_FLAGS_ACCOUNT_CONSISTENCY_NAME, 1234 {"enable-account-consistency", IDS_FLAGS_ACCOUNT_CONSISTENCY_NAME,
1233 IDS_FLAGS_ACCOUNT_CONSISTENCY_DESCRIPTION, kOsAll, 1235 IDS_FLAGS_ACCOUNT_CONSISTENCY_DESCRIPTION, kOsAll,
(...skipping 976 matching lines...) Expand 10 before | Expand all | Expand 10 after
2210 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2212 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2211 2213
2212 const FeatureEntry* GetFeatureEntries(size_t* count) { 2214 const FeatureEntry* GetFeatureEntries(size_t* count) {
2213 *count = arraysize(kFeatureEntries); 2215 *count = arraysize(kFeatureEntries);
2214 return kFeatureEntries; 2216 return kFeatureEntries;
2215 } 2217 }
2216 2218
2217 } // namespace testing 2219 } // namespace testing
2218 2220
2219 } // namespace about_flags 2221 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698