[iOS] Define build/config/ios:ios_dynamic_flags for default linker flags.

[iOS] Define build/config/ios:ios_dynamic_flags for default linker flags.

BUG=None

Committed: https://crrev.com/ff574fee1d11575e1ffd55715accbbd97ebfbd96
Cr-Commit-Position: refs/heads/master@{#406905}

[sdefresne, 2016-07-20 16:03:18]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-07-20 16:03:42]

sdefresne@chromium.org changed reviewers:
+ rsesek@chromium.org

[sdefresne, 2016-07-20 16:03:42]

Please take a look.

[commit-bot: I haz the power, 2016-07-20 16:03:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-07-20 16:21:08]

LGTM

https://codereview.chromium.org/2166663003/diff/1/build/config/ios/BUILD.gn
File build/config/ios/BUILD.gn (right):

https://codereview.chromium.org/2166663003/diff/1/build/config/ios/BUILD.gn#n...
build/config/ios/BUILD.gn:45: "-objc_abi_version",
I'm not familiar with this. Why is it required?

[sdefresne, 2016-07-20 16:25:58]

On 2016/07/20 16:21:08, Robert Sesek wrote:
> LGTM
> 
> https://codereview.chromium.org/2166663003/diff/1/build/config/ios/BUILD.gn
> File build/config/ios/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2166663003/diff/1/build/config/ios/BUILD.gn#n...
> build/config/ios/BUILD.gn:45: "-objc_abi_version",
> I'm not familiar with this. Why is it required?

It is set for all executable and dynamic library target with gyp currently.
Looking at clang code it looks like it change some ABI when targeting x86 cpus
according to google search results.

I'm unconvinced that this is required, but I prefer to have it defined in gn too
to reduce differences between gyp and gn builds. I can add a TODO to remove it
later if you want.

[Robert Sesek, 2016-07-20 16:27:03]

On 2016/07/20 16:25:58, sdefresne wrote:
> On 2016/07/20 16:21:08, Robert Sesek wrote:
> > LGTM
> > 
> > https://codereview.chromium.org/2166663003/diff/1/build/config/ios/BUILD.gn
> > File build/config/ios/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2166663003/diff/1/build/config/ios/BUILD.gn#n...
> > build/config/ios/BUILD.gn:45: "-objc_abi_version",
> > I'm not familiar with this. Why is it required?
> 
> It is set for all executable and dynamic library target with gyp currently.
> Looking at clang code it looks like it change some ABI when targeting x86 cpus
> according to google search results.
> 
> I'm unconvinced that this is required, but I prefer to have it defined in gn
too
> to reduce differences between gyp and gn builds. I can add a TODO to remove it
> later if you want.

I codesearched it and didn't see this getting set for GYP?
https://cs.chromium.org/search/?q=objc_abi_version&sq=package:chromium&type=cs

[sdefresne, 2016-07-20 16:28:34]

On 2016/07/20 16:27:03, Robert Sesek wrote:
> On 2016/07/20 16:25:58, sdefresne wrote:
> > On 2016/07/20 16:21:08, Robert Sesek wrote:
> > > LGTM
> > > 
> > >
https://codereview.chromium.org/2166663003/diff/1/build/config/ios/BUILD.gn
> > > File build/config/ios/BUILD.gn (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2166663003/diff/1/build/config/ios/BUILD.gn#n...
> > > build/config/ios/BUILD.gn:45: "-objc_abi_version",
> > > I'm not familiar with this. Why is it required?
> > 
> > It is set for all executable and dynamic library target with gyp currently.
> > Looking at clang code it looks like it change some ABI when targeting x86
cpus
> > according to google search results.
> > 
> > I'm unconvinced that this is required, but I prefer to have it defined in gn
> too
> > to reduce differences between gyp and gn builds. I can add a TODO to remove
it
> > later if you want.
> 
> I codesearched it and didn't see this getting set for GYP?
> https://cs.chromium.org/search/?q=objc_abi_version&sq=package:chromium&type=cs

Ah, it is only set for downstream targets then. I'll remove it from this config
and create one for downstream.

[commit-bot: I haz the power, 2016-07-20 17:08:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 17:08:01]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-07-21 15:27:49]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 15:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-07-21 15:28:22]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-07-21 15:28:22]

dpranke: can you review as OWNERS?

[commit-bot: I haz the power, 2016-07-21 16:31:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 16:31:58]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-07-21 17:08:35]

lgtm

[sdefresne, 2016-07-21 18:02:46]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-07-21 18:02:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2166663003/#ps20001
(title: "Remove -Xlinker -objc_abi_version -Xlinker 2.")

[commit-bot: I haz the power, 2016-07-21 18:03:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 18:09:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-21 18:11:47]

Description was changed from

==========
[iOS] Define build/config/ios:ios_dynamic_flags for default linker flags.

BUG=None
==========

to

==========
[iOS] Define build/config/ios:ios_dynamic_flags for default linker flags.

BUG=None

Committed: https://crrev.com/ff574fee1d11575e1ffd55715accbbd97ebfbd96
Cr-Commit-Position: refs/heads/master@{#406905}
==========

[commit-bot: I haz the power, 2016-07-21 18:11:48]

Patchset 2 (id:??) landed as
https://crrev.com/ff574fee1d11575e1ffd55715accbbd97ebfbd96
Cr-Commit-Position: refs/heads/master@{#406905}