Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2166633003: DiscardableZoneScope fix. It was an unintentional noop. (Closed)

Created:
4 years, 5 months ago by marja
Modified:
4 years, 5 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

DiscardableZoneScope fix. It was an unintentional noop. BUG= Committed: https://crrev.com/442801dd0c410591daeb91676a6004028eb82572 Cr-Commit-Position: refs/heads/master@{#37918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
marja
ptal. And then we'll forget this ever happened.
4 years, 5 months ago (2016-07-20 12:05:20 UTC) #2
titzer
lgtm, requires parser owner, though
4 years, 5 months ago (2016-07-20 12:10:09 UTC) #5
marja
I'm a parser owner, isn't that enough? In chromium, it is. Or was. Let's find ...
4 years, 5 months ago (2016-07-20 12:11:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166633003/1
4 years, 5 months ago (2016-07-21 07:03:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 07:07:22 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 07:10:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/442801dd0c410591daeb91676a6004028eb82572
Cr-Commit-Position: refs/heads/master@{#37918}

Powered by Google App Engine
This is Rietveld 408576698