Issue 216663004: Simplify run-bindings-test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216663004: Simplify run-bindings-test (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)

Modified:
6 years, 9 months ago

Reviewers:
haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Simplify run-bindings-test A bit more simplification, while we're at it. We don't need a class for the tests: we're just calling a function once. This removes a lot of OO boilerplace (lots of 'self') and makes the code very functional (an object with a main() method is a code smell). Also simplify path handling (we already know Source/ for Python includes, so we don't need to ask the source control system for it). R=haraken BUG=341748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170323