Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2166623002: Fix color order for 565,4444, and I8 samplers. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix color order for 565,4444, and I8 samplers. 10 GMs fixed on Linux/Win! Also, don't unpremul I8 colors. It's inconsistent with the other formats. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166623002 Committed: https://skia.googlesource.com/skia/+/53574b72362a5b85f75c359966a1ca2066bad2a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -24 lines) Patch
M src/core/SkLinearBitmapPipeline_sample.h View 4 chunks +11 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mtklein_C
4 years, 5 months ago (2016-07-19 22:09:42 UTC) #5
herb_g
lgtm
4 years, 5 months ago (2016-07-20 12:22:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166623002/1
4 years, 5 months ago (2016-07-20 12:22:37 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 12:23:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/53574b72362a5b85f75c359966a1ca2066bad2a6

Powered by Google App Engine
This is Rietveld 408576698