DevTools: roll CodeMirror

DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
R=lushnikov@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/de8ddaf523711eedcfc00fa64aa527bd2ee57212

[einbinder, 2016-07-19 20:30:21]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-07-19 20:30:22]

https://codereview.chromium.org/2166603002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/2166603002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1210:
this._codeMirror.addLineClass(lineHandle, "gutter", className);
I'm not sure if always adding a gutter lineclass is the right solution.

[einbinder, 2016-07-19 20:59:02]

Description was changed from

==========
DevTools: roll CodeMirror
Fixing soft undo

BUG=618803
==========

to

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
==========

[lushnikov, 2016-07-20 01:40:14]

lgtm % comments

1. Please, start a discussion on https://github.com/codemirror/CodeMirror to
resolve our issues with testing harness. Maybe codemirror would be able to
provide us with a better primitives?

2. You should also roll cm_modes files

https://codereview.chromium.org/2166603002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/2166603002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1210:
this._codeMirror.addLineClass(lineHandle, "gutter", className);
On 2016/07/19 20:30:21, einbinder wrote:
> I'm not sure if always adding a gutter lineclass is the right solution.

Thats' fine

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/editor/editor-test.js (right):

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/editor/editor-test.js:69: var character
= typeText[charIndex];
typeText[charIndex++]

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/editor/editor-test.js:75: callback =
iterationCallback;
should we do this?

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/editor/editor-test.js:98: if (callback
=== noop) {
nit: braces

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/cm/htmlembedded.js (right):

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/cm/htmlembedded.js:2: //
Distributed under an MIT license: http://codemirror.net/LICENSE
let's move this mode into cm_modes in the follow-up

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/cm/htmlembedded.js:17: return
CodeMirror.multiplexingMode(CodeMirror.getMode(config, "htmlmixed"), {
don't we have to add this mode?

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1212:
}
nit: else on the same line with }

[einbinder, 2016-07-21 02:08:19]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-07-21 02:08:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2166603002/#ps40001
(title: "Add cm_modes and multiplex.js")

[commit-bot: I haz the power, 2016-07-21 02:08:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 02:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 02:18:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lushnikov, 2016-07-21 16:54:25]

https://codereview.chromium.org/2166603002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/editor/editor-test.js (right):

https://codereview.chromium.org/2166603002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/editor/editor-test.js:66: var character
= typeText[charIndex];
how's this code different from the old one? I don't see functional changes.

https://codereview.chromium.org/2166603002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/source_frame/module.json
(right):

https://codereview.chromium.org/2166603002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/module.json:37:
"../cm/multiplex.js",
nit: i'd put multiplex before htmlmixed to mirror the dependency

[einbinder, 2016-07-21 17:47:09]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-07-21 17:47:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2166603002/#ps60001
(title: "Revert unnecessary typeIn change")

[commit-bot: I haz the power, 2016-07-21 17:47:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 17:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 17:54:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[einbinder, 2016-07-21 20:35:31]

Description was changed from

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
==========

to

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
NOTRY=true
==========

[einbinder, 2016-07-21 20:35:51]

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/editor/editor-test.js (right):

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/editor/editor-test.js:69: var character
= typeText[charIndex];
On 2016/07/20 01:40:13, lushnikov wrote:
> typeText[charIndex++]

Done.

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/editor/editor-test.js:75: callback =
iterationCallback;
On 2016/07/20 01:40:13, lushnikov wrote:
> should we do this?

nope

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/editor/editor-test.js:98: if (callback
=== noop) {
On 2016/07/20 01:40:13, lushnikov wrote:
> nit: braces

Done.

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/cm/htmlembedded.js (right):

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/cm/htmlembedded.js:17: return
CodeMirror.multiplexingMode(CodeMirror.getMode(config, "htmlmixed"), {
On 2016/07/20 01:40:13, lushnikov wrote:
> don't we have to add this mode?

Done.

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/2166603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1212:
}
On 2016/07/20 01:40:13, lushnikov wrote:
> nit: else on the same line with }

Done.

https://codereview.chromium.org/2166603002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/editor/editor-test.js (right):

https://codereview.chromium.org/2166603002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/editor/editor-test.js:66: var character
= typeText[charIndex];
On 2016/07/21 16:54:25, lushnikov wrote:
> how's this code different from the old one? I don't see functional changes.

Oh, I guess it turned out the same

https://codereview.chromium.org/2166603002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/source_frame/module.json
(right):

https://codereview.chromium.org/2166603002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/module.json:37:
"../cm/multiplex.js",
On 2016/07/21 16:54:25, lushnikov wrote:
> nit: i'd put multiplex before htmlmixed to mirror the dependency

Done.

[einbinder, 2016-07-21 20:36:07]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:36:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 20:50:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:50:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[einbinder, 2016-07-21 20:59:06]

Description was changed from

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
NOTRY=true
==========

to

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
==========

[commit-bot: I haz the power, 2016-07-22 22:46:23]

Description was changed from

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
==========

to

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
R=lushnikov@chromium.org

Committed: https://crrev.com/de8ddaf523711eedcfc00fa64aa527bd2ee57212
Cr-Commit-Position: refs/heads/master@{#407285}
==========

[commit-bot: I haz the power, 2016-07-22 22:46:24]

Patchset 4 (id:??) landed as
https://crrev.com/de8ddaf523711eedcfc00fa64aa527bd2ee57212
Cr-Commit-Position: refs/heads/master@{#407285}

[lushnikov, 2016-07-22 22:47:19]

Description was changed from

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
R=lushnikov@chromium.org

Committed: https://crrev.com/de8ddaf523711eedcfc00fa64aa527bd2ee57212
Cr-Commit-Position: refs/heads/master@{#407285}
==========

to

==========
DevTools: roll CodeMirror 5.17.1
Fixing soft undo

BUG=618803
R=lushnikov@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/de8ddaf523711eedcfc00fa64aa5...
==========

[lushnikov, 2016-07-22 22:47:22]

Committed patchset #4 (id:60001) manually as
de8ddaf523711eedcfc00fa64aa527bd2ee57212 (presubmit successful).