content/browser/renderer_host/text_input_manager.cc - Issue 2166573003: Track TextInputState from multiple RenderWidgets in TextInputManager (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/text_input_manager.cc

Issue 2166573003: Track TextInputState from multiple RenderWidgets in TextInputManager (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabled SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames on Mac since the corresp… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/text_input_manager.cc

diff --git a/content/browser/renderer_host/text_input_manager.cc b/content/browser/renderer_host/text_input_manager.cc

index faee51cc3cb9aad16e0cc340afe87ed2c3f54296..dc0b5585d208642f8b690c41776b9b307f972b3b 100644

--- a/content/browser/renderer_host/text_input_manager.cc

+++ b/content/browser/renderer_host/text_input_manager.cc

@@ -21,6 +21,9 @@ bool AreDifferentTextInputStates(const content::TextInputState& old_state,

return old_state.type != new_state.type || old_state.mode != new_state.mode ||

old_state.flags != new_state.flags ||

old_state.can_compose_inline != new_state.can_compose_inline;

+#elif defined(OS_MACOSX)

+ return old_state.type != new_state.type ||

+ old_state.can_compose_inline != new_state.can_compose_inline;

#else

// TODO(ekaramad): Implement the logic for other platforms (crbug.com/578168).

NOTREACHED();