Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2166573003: Track TextInputState from multiple RenderWidgets in TextInputManager (Mac) (Closed)

Created:
4 years, 5 months ago by EhsanK
Modified:
4 years, 4 months ago
Reviewers:
kenrb, Charlie Reis
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track TextInputState from multiple RenderWidgets in TextInputManager (Mac) This CL implements the logic to track TextInputState in TextInputManager for OOPIF structure on Mac. A similar implementation was landed on Aura here: https://codereview.chromium.org/1948343002. The CL also activates the corresponding TextInputManager tests on Mac. BUG=578168, 602723, 602427 Committed: https://crrev.com/c3ef49d3c300e954f631acfe601b6276a3b5b89f Cr-Commit-Position: refs/heads/master@{#408199}

Patch Set 1 #

Patch Set 2 : Enabled Interactive Tests on Mac #

Patch Set 3 : Rebased + Made GetTextInputType() private. #

Patch Set 4 : GetTextInputType() must be public to be accessed by the Cocoa view #

Total comments: 12

Patch Set 5 : Addressing kenrb@'s and creis@'s comments #

Patch Set 6 : Rebased #

Patch Set 7 : Disabled SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames on Mac since the corresp… #

Total comments: 6

Patch Set 8 : Addressing creis@'s comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -37 lines) Patch
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 1 2 3 4 5 6 7 5 chunks +20 lines, -8 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 6 chunks +10 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 8 chunks +33 lines, -19 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 46 (30 generated)
EhsanK
Ken, Charlie: PTAL. I will continue adding more browser side code for Mac and enable ...
4 years, 5 months ago (2016-07-21 19:55:04 UTC) #13
kenrb
https://codereview.chromium.org/2166573003/diff/60001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc File chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc (right): https://codereview.chromium.org/2166573003/diff/60001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc#newcode510 chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:510: // corresponding feature is implemented (http://crbug.com/578168). Is it much ...
4 years, 5 months ago (2016-07-21 21:48:16 UTC) #16
Charlie Reis
Exciting to see Mac moving over as well! LGTM once Ken's happy. https://codereview.chromium.org/2166573003/diff/60001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc File chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ...
4 years, 5 months ago (2016-07-22 20:59:35 UTC) #17
EhsanK
Thanks for the reviews! PTAL. https://codereview.chromium.org/2166573003/diff/60001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc File chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc (right): https://codereview.chromium.org/2166573003/diff/60001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc#newcode29 chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:29: // TODO(ekaramad): The following ...
4 years, 5 months ago (2016-07-25 17:12:02 UTC) #19
Charlie Reis
Thanks! https://codereview.chromium.org/2166573003/diff/60001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc File chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc (right): https://codereview.chromium.org/2166573003/diff/60001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc#newcode510 chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc:510: // corresponding feature is implemented (http://crbug.com/578168). On 2016/07/25 ...
4 years, 5 months ago (2016-07-25 19:43:55 UTC) #20
kenrb
lgtm
4 years, 4 months ago (2016-07-26 20:44:55 UTC) #21
EhsanK
Thanks for the reviews! I will commit after dry-run.
4 years, 4 months ago (2016-07-26 20:49:22 UTC) #23
Charlie Reis
On 2016/07/26 20:49:22, EhsanK wrote: > Thanks for the reviews! I will commit after dry-run. ...
4 years, 4 months ago (2016-07-26 23:56:21 UTC) #29
EhsanK
On 2016/07/26 23:56:21, Charlie Reis wrote: > On 2016/07/26 20:49:22, EhsanK wrote: > > Thanks ...
4 years, 4 months ago (2016-07-27 00:08:57 UTC) #30
EhsanK
On 2016/07/27 00:08:57, EhsanK wrote: > On 2016/07/26 23:56:21, Charlie Reis wrote: > > On ...
4 years, 4 months ago (2016-07-27 00:10:25 UTC) #31
Charlie Reis
Thanks for clarifying. From the diff between patches, I first couldn't tell if we were ...
4 years, 4 months ago (2016-07-27 16:14:18 UTC) #34
EhsanK
Thanks Charlie! Updated the comments and added a few notes. https://codereview.chromium.org/2166573003/diff/140001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc File chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc (right): https://codereview.chromium.org/2166573003/diff/140001/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc#newcode523 ...
4 years, 4 months ago (2016-07-27 16:46:32 UTC) #37
Charlie Reis
LGTM
4 years, 4 months ago (2016-07-27 18:08:05 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166573003/160001
4 years, 4 months ago (2016-07-27 18:08:53 UTC) #42
commit-bot: I haz the power
Committed patchset #8 (id:160001)
4 years, 4 months ago (2016-07-27 18:38:43 UTC) #44
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 18:41:58 UTC) #46
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/c3ef49d3c300e954f631acfe601b6276a3b5b89f
Cr-Commit-Position: refs/heads/master@{#408199}

Powered by Google App Engine
This is Rietveld 408576698