Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2166553003: Revert of Mojo interface/service for Leak Detector on remote process (Closed)

Created:
4 years, 5 months ago by achuithb
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, asvitkine+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), dcheng, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo interface/service for Leak Detector on remote process (patchset #20 id:400001 of https://codereview.chromium.org/2064463002/ ) Reason for revert: crbug.com/629760 Original issue's description: > Mojo interface/service for Leak Detector on remote process > > This interface allows an instance of the Runtime Memory Leak Detector > (components/metrics/leak_detector) to run on a non-browser process, such > as a tab (renderer) process. The interface provides two function APIs: > > - GetParams(): Returns the profiling parameters used for initializing > LeakDetector. > - SendLeakReports(): Passes an array of leak reports to the browser process, > where they can be attached to the UMA protobuf. > > Also added an implementation of the Mojo interface, > LeakDetectorRemoteController, that implements the Mojo interface > LeakDetectorRemote. This class provides a bridge between the browser and > renderer processes. It also allows a single instance of > LeakDetectorController to provide leak detector params to the renderer > process and receive leak reports from the renderer process. > > BUG=chromium:615223 > TEST=Build successfully, unit tests pass > R=wfh@chromium.org > > Committed: https://crrev.com/c21a6e92a02f064431b22aa52b136f4682778c06 > Cr-Commit-Position: refs/heads/master@{#406466} TBR=jochen@chromium.org,ben@chromium.org,dcheng@chromium.org,isherman@chromium.org,wfh@chromium.org,sque@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:615223 Committed: https://crrev.com/adb91a497c2a4624d4cf19f1b381e3df65b0a16d Cr-Commit-Position: refs/heads/master@{#406511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -692 lines) Patch
M chrome/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/metrics/leak_detector/leak_detector_controller.h View 3 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/metrics/leak_detector/leak_detector_controller.cc View 1 chunk +6 lines, -27 lines 0 comments Download
D chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/renderer/leak_detector/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/renderer/leak_detector/leak_detector_remote_client.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/renderer/leak_detector/leak_detector_remote_client.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
M components/metrics/BUILD.gn View 3 chunks +54 lines, -3 lines 0 comments Download
D components/metrics/leak_detector/BUILD.gn View 1 chunk +0 lines, -65 lines 0 comments Download
M components/metrics/leak_detector/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D components/metrics/leak_detector/leak_detector.mojom View 1 chunk +0 lines, -40 lines 0 comments Download
D components/metrics/leak_detector/protobuf_to_mojo_converter.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/metrics/leak_detector/protobuf_to_mojo_converter.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc View 1 chunk +0 lines, -139 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
achuithb
Created Revert of Mojo interface/service for Leak Detector on remote process
4 years, 5 months ago (2016-07-20 07:24:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166553003/1
4 years, 5 months ago (2016-07-20 07:25:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 07:27:33 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 07:29:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adb91a497c2a4624d4cf19f1b381e3df65b0a16d
Cr-Commit-Position: refs/heads/master@{#406511}

Powered by Google App Engine
This is Rietveld 408576698