Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2166553002: PPC/s390: [builtins] Introduce a builtin for Abort(). (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Introduce a builtin for Abort(). Port 9be015a254cfff871c56cd129523a729637e9158 Original commit message: Calling Runtime::kAbort through a builtin instead of the c-entry stub will allow to generate the call in a background thread, because a builtin provides its own handle, whereas a code stub does not. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/a660062de542328d3c25329838a1d0646f815b0d Cr-Commit-Position: refs/heads/master@{#37877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-07-19 17:58:53 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-07-19 18:00:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166553002/1
4 years, 5 months ago (2016-07-19 18:00:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 18:22:54 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:25:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a660062de542328d3c25329838a1d0646f815b0d
Cr-Commit-Position: refs/heads/master@{#37877}

Powered by Google App Engine
This is Rietveld 408576698