Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2166533002: Fix color order on LCD text when using sRGB software backend. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix color order on LCD text when using sRGB software backend. BUG=skia:5182 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166533002 Committed: https://skia.googlesource.com/skia/+/35f255f0f77dd0dea58d2f7aa07f6ec8b3994819

Patch Set 1 #

Patch Set 2 : One more. #

Patch Set 3 : the other two #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/core/SkXfermode4f.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
mtklein_C
4 years, 5 months ago (2016-07-19 17:50:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166533002/1
4 years, 5 months ago (2016-07-19 17:50:55 UTC) #5
mtklein_C
Ben and I noticed this was drawing wrong the other day while debugging my pipeline ...
4 years, 5 months ago (2016-07-19 18:00:31 UTC) #7
Brian Osman
Should be able to close skbug.com/5182
4 years, 5 months ago (2016-07-19 18:59:27 UTC) #13
mtklein
On 2016/07/19 18:59:27, Brian Osman wrote: > Should be able to close skbug.com/5182 Ah, thanks. ...
4 years, 5 months ago (2016-07-19 19:23:17 UTC) #15
reed1
lgtm
4 years, 5 months ago (2016-07-19 19:57:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166533002/40001
4 years, 5 months ago (2016-07-19 19:58:41 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 19:59:38 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/35f255f0f77dd0dea58d2f7aa07f6ec8b3994819

Powered by Google App Engine
This is Rietveld 408576698