Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: extensions/renderer/worker_thread_dispatcher.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync@tott Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/worker_thread_dispatcher.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/worker_thread_dispatcher.cc
diff --git a/extensions/renderer/worker_thread_dispatcher.cc b/extensions/renderer/worker_thread_dispatcher.cc
index cc9fdc88def46f24c9098d002ff89d0cb44914c8..0d189d44fbde279f860e3180b2e70771793c0fbd 100644
--- a/extensions/renderer/worker_thread_dispatcher.cc
+++ b/extensions/renderer/worker_thread_dispatcher.cc
@@ -24,8 +24,10 @@ void OnResponseOnWorkerThread(int request_id,
bool succeeded,
const std::unique_ptr<base::ListValue>& response,
const std::string& error) {
- WorkerThreadDispatcher::GetRequestSender()->HandleResponse(
- request_id, succeeded, *response, error);
+ ServiceWorkerData* data = g_data_tls.Pointer()->Get();
+ WorkerThreadDispatcher::GetRequestSender()->HandleWorkerResponse(
+ request_id, data->service_worker_version_id(), succeeded, *response,
+ error);
}
} // namespace
@@ -52,7 +54,7 @@ V8SchemaRegistry* WorkerThreadDispatcher::GetV8SchemaRegistry() {
}
// static
-RequestSender* WorkerThreadDispatcher::GetRequestSender() {
+ServiceWorkerRequestSender* WorkerThreadDispatcher::GetRequestSender() {
ServiceWorkerData* data = g_data_tls.Pointer()->Get();
DCHECK(data);
return data->request_sender();
@@ -84,19 +86,20 @@ void WorkerThreadDispatcher::OnResponseWorker(int worker_thread_id,
base::Passed(response.CreateDeepCopy()), error));
}
-void WorkerThreadDispatcher::AddWorkerData(int embedded_worker_id) {
+void WorkerThreadDispatcher::AddWorkerData(int64_t service_worker_version_id) {
ServiceWorkerData* data = g_data_tls.Pointer()->Get();
if (!data) {
ServiceWorkerData* new_data =
- new ServiceWorkerData(this, embedded_worker_id);
+ new ServiceWorkerData(this, service_worker_version_id);
g_data_tls.Pointer()->Set(new_data);
}
}
-void WorkerThreadDispatcher::RemoveWorkerData(int embedded_worker_id) {
+void WorkerThreadDispatcher::RemoveWorkerData(
+ int64_t service_worker_version_id) {
ServiceWorkerData* data = g_data_tls.Pointer()->Get();
if (data) {
- DCHECK_EQ(embedded_worker_id, data->embedded_worker_id());
+ DCHECK_EQ(service_worker_version_id, data->service_worker_version_id());
delete data;
g_data_tls.Pointer()->Set(nullptr);
}
« no previous file with comments | « extensions/renderer/worker_thread_dispatcher.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698