Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: extensions/browser/bad_message.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync@tott Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/bad_message.h ('k') | extensions/browser/extension_function.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/bad_message.cc
diff --git a/extensions/browser/bad_message.cc b/extensions/browser/bad_message.cc
index 520610a68e0f1e29014ac227315461a5b6aeaefe..bae713ea3764dd4c141c93fecd88e83795f22ac2 100644
--- a/extensions/browser/bad_message.cc
+++ b/extensions/browser/bad_message.cc
@@ -6,20 +6,35 @@
#include "base/logging.h"
#include "base/metrics/sparse_histogram.h"
+#include "content/public/browser/browser_message_filter.h"
#include "content/public/browser/render_process_host.h"
namespace extensions {
namespace bad_message {
-void ReceivedBadMessage(content::RenderProcessHost* host,
- BadMessageReason reason) {
+namespace {
+
+void LogBadMessage(BadMessageReason reason) {
LOG(ERROR) << "Terminating extension renderer for bad IPC message, reason "
<< reason;
UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.Extensions",
reason);
+}
+
+} // namespace
+
+void ReceivedBadMessage(content::RenderProcessHost* host,
+ BadMessageReason reason) {
+ LogBadMessage(reason);
host->ShutdownForBadMessage(
content::RenderProcessHost::CrashReportMode::GENERATE_CRASH_DUMP);
}
+void ReceivedBadMessage(content::BrowserMessageFilter* filter,
+ BadMessageReason reason) {
+ LogBadMessage(reason);
+ filter->ShutdownForBadMessage();
+}
+
} // namespace bad_message
} // namespace extensions
« no previous file with comments | « extensions/browser/bad_message.h ('k') | extensions/browser/extension_function.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698