Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync@tott Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index e2459fd76c08e702fdc0ffa84095881d4b0f0cf5..310e76e3d8a69cf6821c14c13f66bb4ec0810e69 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -78,6 +78,8 @@ std::string EventTypeToSuffix(ServiceWorkerMetrics::EventType event_type) {
return "_NAVIGATION_HINT_LINK_TAP_UNCONFIRMED";
case ServiceWorkerMetrics::EventType::NAVIGATION_HINT_LINK_TAP_DOWN:
return "_NAVIGATION_HINT_LINK_TAP_DOWN";
+ case ServiceWorkerMetrics::EventType::EXTERNAL_REQUEST:
+ return "_EXTERNAL_REQUEST";
case ServiceWorkerMetrics::EventType::NUM_TYPES:
NOTREACHED() << static_cast<int>(event_type);
}
@@ -227,6 +229,8 @@ const char* ServiceWorkerMetrics::EventTypeToString(EventType event_type) {
return "Navigation Hint Link Tap Unconfirmed";
case EventType::NAVIGATION_HINT_LINK_TAP_DOWN:
return "Navigation Hint Link Tap Down";
+ case EventType::EXTERNAL_REQUEST:
+ return "External Request";
case EventType::NUM_TYPES:
break;
}
@@ -565,6 +569,9 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,
UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.ExtendableMessageEvent.Time",
time);
break;
+ case EventType::EXTERNAL_REQUEST:
+ UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.ExternalRequest.Time", time);
+ break;
// Those navigation hints should not be sent as request events.
case EventType::NAVIGATION_HINT_LINK_MOUSE_DOWN:
case EventType::NAVIGATION_HINT_LINK_TAP_UNCONFIRMED:
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.h ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698