content/renderer/service_worker/service_worker_context_client.cc - Issue 2166523003: Add ref count to service workers for extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address test comments + rename public methods Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/service_worker_context.h ('K') | « content/public/renderer/content_renderer_client.h ('k') | extensions/browser/bad_message.h » ('j') | extensions/common/extension_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.cc

diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc

index 50b7c5d201f73aa78f435bdbe134683b20d0ca71..a1deda7c63e649ad363cc8ca65c0fbd9d17cf08f 100644

--- a/content/renderer/service_worker/service_worker_context_client.cc

+++ b/content/renderer/service_worker/service_worker_context_client.cc

@@ -455,7 +455,7 @@ void ServiceWorkerContextClient::didInitializeWorkerContext(

GetContentClient()

->renderer()

->DidInitializeServiceWorkerContextOnWorkerThread(

- context, embedded_worker_id_, script_url_);

+ context, service_worker_version_id_, script_url_);

}

void ServiceWorkerContextClient::willDestroyWorkerContext(

@@ -474,7 +474,7 @@ void ServiceWorkerContextClient::willDestroyWorkerContext(

g_worker_client_tls.Pointer()->Set(NULL);

GetContentClient()->renderer()->WillDestroyServiceWorkerContextOnWorkerThread(

- context, embedded_worker_id_, script_url_);

+ context, service_worker_version_id_, script_url_);

}

void ServiceWorkerContextClient::workerContextDestroyed() {