Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6496)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from Devlin & MichaelN Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 9da2a604734032c954318beaa3af6b7834b200be..748e3b8f16aca5af983c5fa8837c895f04ab810e 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -1380,23 +1380,23 @@ void ChromeContentRendererClient::RunScriptsAtDocumentEnd(
void ChromeContentRendererClient::
DidInitializeServiceWorkerContextOnWorkerThread(
v8::Local<v8::Context> context,
- int embedded_worker_id,
+ int64_t service_worker_version_id,
const GURL& url) {
#if defined(ENABLE_EXTENSIONS)
ChromeExtensionsRendererClient::GetInstance()
->extension_dispatcher()
->DidInitializeServiceWorkerContextOnWorkerThread(
- context, embedded_worker_id, url);
+ context, service_worker_version_id, url);
#endif
}
void ChromeContentRendererClient::WillDestroyServiceWorkerContextOnWorkerThread(
v8::Local<v8::Context> context,
- int embedded_worker_id,
+ int64_t service_worker_version_id,
const GURL& url) {
#if defined(ENABLE_EXTENSIONS)
extensions::Dispatcher::WillDestroyServiceWorkerContextOnWorkerThread(
- context, embedded_worker_id, url);
+ context, service_worker_version_id, url);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698