Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: content/browser/service_worker/service_worker_context_wrapper.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from Devlin Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_wrapper.cc
diff --git a/content/browser/service_worker/service_worker_context_wrapper.cc b/content/browser/service_worker/service_worker_context_wrapper.cc
index eeac4d3bfa1a06a2f5aa0af8950ffaa784dac6ae..4a6aa89aa426757c52f0817bc06a00ab7cd3c55c 100644
--- a/content/browser/service_worker/service_worker_context_wrapper.cc
+++ b/content/browser/service_worker/service_worker_context_wrapper.cc
@@ -22,6 +22,7 @@
#include "base/threading/sequenced_worker_pool.h"
#include "base/threading/thread_task_runner_handle.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
+#include "content/browser/service_worker/embedded_worker_status.h"
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_context_observer.h"
#include "content/browser/service_worker/service_worker_process_manager.h"
@@ -832,6 +833,32 @@ void ServiceWorkerContextWrapper::ShutdownOnIO() {
context_core_.reset();
}
+bool ServiceWorkerContextWrapper::IncrementPendingActivity(
+ int64_t service_worker_version_id,
+ const std::string& request_uuid) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ ServiceWorkerVersion* version =
+ context()->GetLiveVersion(service_worker_version_id);
+ if (!version)
+ return false;
+
michaeln 2016/10/06 19:22:31 whitespace nit: blank line not needed + might as w
lazyboy 2016/10/07 06:00:57 Done.
+ return version->StartExternalRequest(request_uuid);
+}
+
+bool ServiceWorkerContextWrapper::DecrementPendingActivity(
+ int64_t service_worker_version_id,
+ const std::string& request_uuid) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+ ServiceWorkerVersion* version =
+ context()->GetLiveVersion(service_worker_version_id);
+
+ if (!version)
+ return false;
+
+ return version->FinishExternalRequest(request_uuid);
+}
+
void ServiceWorkerContextWrapper::DidDeleteAndStartOver(
ServiceWorkerStatusCode status) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);

Powered by Google App Engine
This is Rietveld 408576698