Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: extensions/renderer/dispatcher.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from falken@ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index ae1ba0ee8f6e56317a4567022fec00308760269e..216d3f8aaf50e8845a28aa135947380ba633b8c4 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -87,6 +87,7 @@
#include "extensions/renderer/script_injection.h"
#include "extensions/renderer/script_injection_manager.h"
#include "extensions/renderer/send_request_natives.h"
+#include "extensions/renderer/service_worker_request_sender.h"
#include "extensions/renderer/set_icon_natives.h"
#include "extensions/renderer/static_v8_external_one_byte_string_resource.h"
#include "extensions/renderer/test_features_native_handler.h"
@@ -397,7 +398,7 @@ void Dispatcher::DidCreateScriptContext(
void Dispatcher::DidInitializeServiceWorkerContextOnWorkerThread(
v8::Local<v8::Context> v8_context,
- int embedded_worker_id,
+ int64_t service_worker_version_id,
const GURL& url) {
const base::TimeTicks start_time = base::TimeTicks::Now();
@@ -443,7 +444,7 @@ void Dispatcher::DidInitializeServiceWorkerContextOnWorkerThread(
context->set_url(url);
if (ExtensionsClient::Get()->ExtensionAPIEnabledInExtensionServiceWorkers()) {
- WorkerThreadDispatcher::Get()->AddWorkerData(embedded_worker_id);
+ WorkerThreadDispatcher::Get()->AddWorkerData(service_worker_version_id);
{
// TODO(lazyboy): Make sure accessing |source_map_| in worker thread is
// safe.
@@ -537,7 +538,7 @@ void Dispatcher::WillReleaseScriptContext(
// static
void Dispatcher::WillDestroyServiceWorkerContextOnWorkerThread(
v8::Local<v8::Context> v8_context,
- int embedded_worker_id,
+ int64_t service_worker_version_id,
const GURL& url) {
if (url.SchemeIs(kExtensionScheme) ||
url.SchemeIs(kExtensionResourceScheme)) {
@@ -545,7 +546,7 @@ void Dispatcher::WillDestroyServiceWorkerContextOnWorkerThread(
g_worker_script_context_set.Get().Remove(v8_context, url);
}
if (ExtensionsClient::Get()->ExtensionAPIEnabledInExtensionServiceWorkers())
- WorkerThreadDispatcher::Get()->RemoveWorkerData(embedded_worker_id);
+ WorkerThreadDispatcher::Get()->RemoveWorkerData(service_worker_version_id);
}
void Dispatcher::DidCreateDocumentElement(blink::WebLocalFrame* frame) {

Powered by Google App Engine
This is Rietveld 408576698