chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js - Issue 2166523003: Add ref count to service workers for extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from falken@ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/service_worker_apitest.cc ('K') | « chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js ('k') | content/browser/service_worker/service_worker_context_wrapper.h » ('j') | content/browser/service_worker/service_worker_context_wrapper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js

diff --git a/chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js b/chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js

index a7e52daeaa9e34c52603a9b69b2c185f3fd00ec0..6000d1aab0b5e857d1cd1d4b626bda3148d9efb0 100644

--- a/chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js

+++ b/chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js

@@ -5,8 +5,11 @@

self.onmessage = function(e) {

if (e.data == 'createTab') {

try {

- chrome.tabs.create({'url': 'http://www.google.com'}, function(tabs) {

- e.ports[0].postMessage('chrome.tabs.create callback');

+ chrome.tabs.create({'url': 'http://www.google.com'}, function(tab) {

+ var id = tab.id;

+ chrome.tabs.update(id, {'url': 'http://www.yahoo.com'}, function(tab) {

+ e.ports[0].postMessage('chrome.tabs.update callback');

+ });

});

} catch (e) {

e.ports[0].postMessage('FAILURE');