chrome/renderer/chrome_content_renderer_client.h - Issue 2166523003: Add ref count to service workers for extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.h

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from falken@ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/service_worker_apitest.cc ('K') | « chrome/browser/extensions/service_worker_apitest.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | content/browser/service_worker/service_worker_context_wrapper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.h

diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h

index 2a834f1936f6eafa12b49864c248c30ba0cc0052..1249d561d410a828654116955e39b97a3b87af37 100644

--- a/chrome/renderer/chrome_content_renderer_client.h

+++ b/chrome/renderer/chrome_content_renderer_client.h

@@ -177,11 +177,11 @@ class ChromeContentRendererClient : public content::ContentRendererClient {

void RunScriptsAtDocumentEnd(content::RenderFrame* render_frame) override;

void DidInitializeServiceWorkerContextOnWorkerThread(

v8::Local<v8::Context> context,

- int embedded_worker_id,

+ int64_t service_worker_version_id,

const GURL& url) override;

void WillDestroyServiceWorkerContextOnWorkerThread(

v8::Local<v8::Context> context,

- int embedded_worker_id,

+ int64_t service_worker_version_id,

const GURL& url) override;

bool ShouldEnforceWebRTCRoutingPreferences() override;

GURL OverrideFlashEmbedWithHTML(const GURL& url) override;