chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js - Issue 2166523003: Add ref count to service workers for extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addres comments from falken@ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/test/data/extensions/api_test/service_worker/tabs_create/sw.js » ('j') | content/browser/service_worker/service_worker_context_wrapper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js

diff --git a/chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js b/chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js

index 0542b5485544a0c5623b18b44e64b0f1cbdb71ca..cd9a466fe7ab107c02f4e9badf2a436e0291abff 100644

--- a/chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js

+++ b/chrome/test/data/extensions/api_test/service_worker/tabs_create/page.js

@@ -9,7 +9,7 @@ var serviceWorkerPromise = new Promise(function(resolve, reject) {

var sw = registration.active;

var channel = new MessageChannel();

channel.port1.onmessage = function(e) {

- if (e.data == 'chrome.tabs.create callback') {

+ if (e.data == 'chrome.tabs.update callback') {

resolve(e.data);

} else {

reject(e.data);