content/public/browser/service_worker_context.h - Issue 2166523003: Add ref count to service workers for extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/service_worker_context.h

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: upload for real this time, address comments from falken@ and michaeln@ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_metrics.h ('K') | « content/browser/service_worker/service_worker_metrics.cc ('k') | content/public/renderer/content_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/service_worker_context.h

diff --git a/content/public/browser/service_worker_context.h b/content/public/browser/service_worker_context.h

index 47f355c734ae46b1a5e17b04968f898a526901c0..a39cb49a7ed7d3f2e805f3043b5da4ceb6245dd5 100644

--- a/content/public/browser/service_worker_context.h

+++ b/content/public/browser/service_worker_context.h

@@ -60,6 +60,9 @@ class ServiceWorkerContext {

const GURL& script_url,

const ResultCallback& callback) = 0;

+ virtual bool IncrementPendingActivity(int64_t service_worker_version_id) = 0;

+ virtual bool DecrementPendingActivity(int64_t service_worker_version_id) = 0;

falken 2016/09/29 14:52:25 Could you add brief comments including that these

lazyboy 2016/09/29 18:07:20 Done.

// Equivalent to calling navigator.serviceWorker.unregister(pattern) from a

// renderer, except that |pattern| is an absolute URL instead of relative to

// some current origin. |callback| is passed true when the JS promise is