chrome/browser/extensions/service_worker_apitest.cc - Issue 2166523003: Add ref count to service workers for extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/service_worker_apitest.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: upload for real this time, address comments from falken@ and michaeln@ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc ('k') | chrome/renderer/chrome_content_renderer_client.h » ('j') | content/browser/service_worker/service_worker_context_wrapper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/service_worker_apitest.cc

diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc

index 227584f99c1a1880ce3d64f2582357edeecf58e3..3ee03f3fbf111b224f87d874c0084b717fd774d2 100644

--- a/chrome/browser/extensions/service_worker_apitest.cc

+++ b/chrome/browser/extensions/service_worker_apitest.cc

@@ -622,7 +622,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, TabsCreate) {

std::string result;

ASSERT_TRUE(content::ExecuteScriptAndExtractString(

web_contents, "window.runServiceWorker()", &result));

- ASSERT_EQ("chrome.tabs.create callback", result);

+ ASSERT_EQ("chrome.tabs.update callback", result);

EXPECT_EQ(starting_tab_count + 1, browser()->tab_strip_model()->count());

// Check extension shutdown path.