Chromium Code Reviews| Index: content/browser/service_worker/service_worker_metrics.cc |
| diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc |
| index e2459fd76c08e702fdc0ffa84095881d4b0f0cf5..c8434503b984b680c8a9ca9858294d15bf89f5ba 100644 |
| --- a/content/browser/service_worker/service_worker_metrics.cc |
| +++ b/content/browser/service_worker/service_worker_metrics.cc |
| @@ -78,6 +78,8 @@ std::string EventTypeToSuffix(ServiceWorkerMetrics::EventType event_type) { |
| return "_NAVIGATION_HINT_LINK_TAP_UNCONFIRMED"; |
| case ServiceWorkerMetrics::EventType::NAVIGATION_HINT_LINK_TAP_DOWN: |
| return "_NAVIGATION_HINT_LINK_TAP_DOWN"; |
| + case ServiceWorkerMetrics::EventType::EXTERNAL_REQUEST: |
| + return "_EXTERNAL_REQUEST"; |
| case ServiceWorkerMetrics::EventType::NUM_TYPES: |
| NOTREACHED() << static_cast<int>(event_type); |
| } |
| @@ -227,6 +229,8 @@ const char* ServiceWorkerMetrics::EventTypeToString(EventType event_type) { |
| return "Navigation Hint Link Tap Unconfirmed"; |
| case EventType::NAVIGATION_HINT_LINK_TAP_DOWN: |
| return "Navigation Hint Link Tap Down"; |
| + case EventType::EXTERNAL_REQUEST: |
| + return "External Request"; |
| case EventType::NUM_TYPES: |
| break; |
| } |
| @@ -565,6 +569,8 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event, |
| UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.ExtendableMessageEvent.Time", |
| time); |
| break; |
| + case EventType::EXTERNAL_REQUEST: |
|
falken
2016/09/23 02:27:35
I think we should have UMA for this, but it could
lazyboy
2016/09/27 21:26:45
Added TODO.
|
| + break; |
| // Those navigation hints should not be sent as request events. |
| case EventType::NAVIGATION_HINT_LINK_MOUSE_DOWN: |
| case EventType::NAVIGATION_HINT_LINK_TAP_UNCONFIRMED: |