Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: extensions/renderer/service_worker_request_sender.cc

Issue 2166523003: Add ref count to service workers for extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addres comments from falken@ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/service_worker_request_sender.h" 5 #include "extensions/renderer/service_worker_request_sender.h"
6 6
7 #include "content/public/child/worker_thread.h" 7 #include "content/public/child/worker_thread.h"
8 #include "extensions/common/extension_messages.h" 8 #include "extensions/common/extension_messages.h"
9 #include "extensions/renderer/worker_thread_dispatcher.h" 9 #include "extensions/renderer/worker_thread_dispatcher.h"
10 10
11 namespace extensions { 11 namespace extensions {
12 12
13 ServiceWorkerRequestSender::ServiceWorkerRequestSender( 13 ServiceWorkerRequestSender::ServiceWorkerRequestSender(
14 WorkerThreadDispatcher* dispatcher, 14 WorkerThreadDispatcher* dispatcher,
15 int embedded_worker_id) 15 int64_t service_worker_version_id)
16 : dispatcher_(dispatcher), embedded_worker_id_(embedded_worker_id) {} 16 : dispatcher_(dispatcher),
17 service_worker_version_id_(service_worker_version_id) {}
17 18
18 ServiceWorkerRequestSender::~ServiceWorkerRequestSender() {} 19 ServiceWorkerRequestSender::~ServiceWorkerRequestSender() {}
19 20
20 void ServiceWorkerRequestSender::SendRequest( 21 void ServiceWorkerRequestSender::SendRequest(
21 content::RenderFrame* render_frame, 22 content::RenderFrame* render_frame,
22 bool for_io_thread, 23 bool for_io_thread,
23 ExtensionHostMsg_Request_Params& params) { 24 ExtensionHostMsg_Request_Params& params) {
24 DCHECK(!render_frame && !for_io_thread); 25 DCHECK(!render_frame && !for_io_thread);
25 int worker_thread_id = content::WorkerThread::GetCurrentId(); 26 int worker_thread_id = content::WorkerThread::GetCurrentId();
26 DCHECK_GT(worker_thread_id, 0); 27 DCHECK_GT(worker_thread_id, 0);
27 params.worker_thread_id = worker_thread_id; 28 params.worker_thread_id = worker_thread_id;
28 params.embedded_worker_id = embedded_worker_id_; 29 params.service_worker_version_id = service_worker_version_id_;
30
31 // Keeps the worker alive during extension function call. Balanced in
32 // HandleWorkerResponse().
33 dispatcher_->Send(new ExtensionHostMsg_IncrementServiceWorkerActivity(
34 service_worker_version_id_));
29 35
30 dispatcher_->Send(new ExtensionHostMsg_RequestWorker(params)); 36 dispatcher_->Send(new ExtensionHostMsg_RequestWorker(params));
31 } 37 }
32 38
39 void ServiceWorkerRequestSender::HandleWorkerResponse(
40 int request_id,
41 int64_t service_worker_version_id,
42 bool success,
43 const base::ListValue& response,
44 const std::string& error) {
45 RequestSender::HandleResponse(request_id, success, response, error);
46
47 dispatcher_->Send(new ExtensionHostMsg_DecrementServiceWorkerActivity(
48 service_worker_version_id_));
49 }
50
33 } // namespace extensions 51 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698