Issue 2166523002: [TEMP DO NOT COMMIT] NewTabPageAdapter for multiple sections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2166523002: [TEMP DO NOT COMMIT] NewTabPageAdapter for multiple sections (Closed)

Created:
4 years, 5 months ago by Philipp Keck

Modified:
4 years, 4 months ago

Reviewers:

CC:
Michael van Ouwerkerk

Base URL:
https://chromium.googlesource.com/chromium/src.git@bridgeumbiegen

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[TEMP DO NOT COMMIT] NewTabPageAdapter for multiple sections BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -11 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java	View	7 chunks	+44 lines, -4 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java	View	5 chunks	+40 lines, -2 lines	1 comment	Download
M	chrome/browser/android/ntp/ntp_snippets_bridge.h	View	1 chunk	+18 lines, -1 line	0 comments	Download
M	chrome/browser/android/ntp/ntp_snippets_bridge.cc	View	3 chunks	+57 lines, -3 lines	0 comments	Download
M	components/ntp_snippets/content_suggestions_category.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2158883002 Patch 60001

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Philipp Keck

4 years, 4 months ago (2016-07-27 16:56:19 UTC) #1

https://codereview.chromium.org/2166523002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
(right):

https://codereview.chromium.org/2166523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java:162:
private SnippetArticle createContentSuggestion(String id, String title, String
url,
Btw I think this is not used and should be removed.

Expand Messages | Collapse Messages