chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc - Issue 2166503003: Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

Issue 2166503003: Fix bluetooth adapter access in SystemTrayDelegateChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not check on InputMethodManager::Get. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/system_tray_delegate_chromeos.cc ('k') | chrome/browser/ui/ash/system_tray_delegate_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

diff --git a/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc b/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

index f57079ab841fdccbaecdd792569b1f723ad6fad0..935c863da67ff15ea71077c21eb46fe73d3a5dc7 100644

--- a/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

+++ b/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

@@ -125,6 +125,14 @@ IN_PROC_BROWSER_TEST_F(SystemTrayDelegateChromeOSTest,

EXPECT_EQ(base::k24HourClock, GetHourType());

}

+// Test that checking bluetooth status early on doesn't cause a crash.

+IN_PROC_BROWSER_TEST_F(SystemTrayDelegateChromeOSTest, BluetoothStatus) {

James Cook 2016/07/20 15:23:14 drive-by question: Any particular reason you added

msw 2016/07/20 16:43:19 Woops, I meant to delete this; thanks for catching

+ SystemTrayDelegateChromeOS delegate;

+ EXPECT_FALSE(delegate.GetBluetoothAvailable());

+ EXPECT_FALSE(delegate.GetBluetoothEnabled());

+ EXPECT_FALSE(delegate.IsBluetoothDiscovering());

// Makes sure that no notifications are shown when rotating the

// display on display settings URLs.

IN_PROC_BROWSER_TEST_F(DisplayNotificationsTest,