Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Check for null adapter in SystemTrayDelegateChromeOS.
Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org

Committed: https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d
Cr-Commit-Position: refs/heads/master@{#406490}

[msw, 2016-07-20 01:02:14]

Description was changed from

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

BUG=626995
==========

to

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

Add a DCHECK with InputMethodManager::Get.
(to parallel similar singleton access methods)

Add a SystemTrayDelegateChromeOS unit test.

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=
==========

[msw, 2016-07-20 01:22:32]

Description was changed from

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

Add a DCHECK with InputMethodManager::Get.
(to parallel similar singleton access methods)

Add a SystemTrayDelegateChromeOS unit test.

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=
==========

to

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

Add a DCHECK with InputMethodManager::Get.
(to parallel similar singleton access methods)

Add a SystemTrayDelegateChromeOS unit test.

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org
==========

[msw, 2016-07-20 01:22:32]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-07-20 01:22:39]

Patchset #2 (id:20001) has been deleted

[msw, 2016-07-20 01:23:05]

Hey Scott, please take a look; thanks!

[msw, 2016-07-20 01:23:49]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 01:24:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-07-20 01:28:35]

Description was changed from

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

Add a DCHECK with InputMethodManager::Get.
(to parallel similar singleton access methods)

Add a SystemTrayDelegateChromeOS unit test.

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org
==========

to

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

Add a DCHECK with InputMethodManager::Get.
(to parallel similar singleton access methods)

Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-07-20 02:20:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 02:20:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-07-20 02:39:11]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 02:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-07-20 02:40:44]

Description was changed from

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

Add a DCHECK with InputMethodManager::Get.
(to parallel similar singleton access methods)

Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org
==========

to

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Check for null adapter in SystemTrayDelegateChromeOS.
Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-07-20 03:52:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 03:52:43]

Dry run: This issue passed the CQ dry run.

[sky, 2016-07-20 04:11:20]

LGTM

[msw, 2016-07-20 04:27:45]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-07-20 04:28:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:34:23]

Description was changed from

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Check for null adapter in SystemTrayDelegateChromeOS.
Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org
==========

to

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Check for null adapter in SystemTrayDelegateChromeOS.
Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-07-20 04:34:24]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-20 04:34:36]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 04:37:32]

Description was changed from

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Check for null adapter in SystemTrayDelegateChromeOS.
Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org
==========

to

==========
Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Check for null adapter in SystemTrayDelegateChromeOS.
Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

BUG=626995
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org

Committed: https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d
Cr-Commit-Position: refs/heads/master@{#406490}
==========

[commit-bot: I haz the power, 2016-07-20 04:37:33]

Patchset 3 (id:??) landed as
https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d
Cr-Commit-Position: refs/heads/master@{#406490}

[James Cook, 2016-07-20 15:23:14]

jamescook@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-07-20 15:23:15]

https://codereview.chromium.org/2166503003/diff/60001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
(right):

https://codereview.chromium.org/2166503003/diff/60001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc:129:
IN_PROC_BROWSER_TEST_F(SystemTrayDelegateChromeOSTest, BluetoothStatus) {
drive-by question: Any particular reason you added the same test as both a
browser test and unit test?

[msw, 2016-07-20 16:43:19]

https://codereview.chromium.org/2166503003/diff/60001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
(right):

https://codereview.chromium.org/2166503003/diff/60001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc:129:
IN_PROC_BROWSER_TEST_F(SystemTrayDelegateChromeOSTest, BluetoothStatus) {
On 2016/07/20 15:23:14, James Cook wrote:
> drive-by question: Any particular reason you added the same test as both a
> browser test and unit test?

Woops, I meant to delete this; thanks for catching that!