Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2166493002: Flip Win x86 builder on chromium waterfall to GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Win x86 builder on chromium waterfall to GN. I missed this when flipping the official builders to GN in r406299. TBR=brettw@chromium.org BUG=623659 Committed: https://crrev.com/203dd1dd1cd691b16d12a8bae541fcc75456b36e Cr-Commit-Position: refs/heads/master@{#406346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-19 17:17:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166493002/1
4 years, 5 months ago (2016-07-19 17:18:45 UTC) #3
brettw
lgtm
4 years, 5 months ago (2016-07-19 17:55:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 19:24:00 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 19:27:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/203dd1dd1cd691b16d12a8bae541fcc75456b36e
Cr-Commit-Position: refs/heads/master@{#406346}

Powered by Google App Engine
This is Rietveld 408576698