Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2166443002: Add config to gclient to pull in Chromedriver test deps. (Closed)

Created:
4 years, 5 months ago by mikecase (-- gone --)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add config to gclient to pull in Chromedriver test deps. BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/1f2c9b78aeda31d7abbda56e2c9cc3f08bdb772b

Patch Set 1 #

Patch Set 2 : Add config to gclient to pull in Chromedriver test deps. #

Patch Set 3 : Add config to gclient to pull in Chromedriver test deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M recipe_modules/gclient/config.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M recipe_modules/gclient/example.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mikecase (-- gone --)
Getting this error on the chromedriver bot.... "/b/build/slave/Android_ChromeDriver_Tests__dbg_/build/src/chrome/test/chromedriver/third_party/java_tests" is empty or it doesn't exist. Need ...
4 years, 5 months ago (2016-07-19 15:30:00 UTC) #2
mikecase (-- gone --)
AHH, nvm this is obvioously wrong lol
4 years, 5 months ago (2016-07-19 15:30:30 UTC) #3
jbudorick
On 2016/07/19 15:30:30, mikecase wrote: > AHH, nvm this is obvioously wrong lol It's wrong ...
4 years, 5 months ago (2016-07-19 15:37:23 UTC) #4
mikecase (-- gone --)
Switched to use custom DEPS. This kinda looks right. +iannucci@ for OWNER For context iannucci, ...
4 years, 5 months ago (2016-07-19 17:23:41 UTC) #6
jbudorick
lgtm
4 years, 5 months ago (2016-07-20 14:11:40 UTC) #7
mikecase (-- gone --)
4 years, 5 months ago (2016-07-20 17:11:05 UTC) #9
ghost stip (do not use)
lgtm
4 years, 5 months ago (2016-07-20 17:12:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166443002/40001
4 years, 5 months ago (2016-07-20 17:13:18 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:17:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/1f2c9b78aeda31...

Powered by Google App Engine
This is Rietveld 408576698