Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 216643002: Reland "Clean up runtime functions for Maths." (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland "Clean up runtime functions for Maths." BUG= R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20328

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -145 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/harmony-math.js View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +1 line, -21 lines 0 comments Download
M src/math.js View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/runtime.h View 1 5 chunks +21 lines, -17 lines 0 comments Download
M src/runtime.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Second patch set includes the fix (reverts MathExp from the change since it needs some ...
6 years, 9 months ago (2014-03-28 09:17:42 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years, 9 months ago (2014-03-28 09:25:29 UTC) #2
Yang
6 years, 9 months ago (2014-03-28 10:07:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698