Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2166423003: [Remoting Android] Fix dragging issue in direct input mode (Closed)

Created:
4 years, 5 months ago by Yuwei
Modified:
4 years, 5 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Fix dragging issue in direct input mode Currently hold-and-press dragging in direct input mode doesn't quite follow the user's finger. The problem is that when the viewport moves (since dragging around), the cursor position will be set to the center of the screen, while the user's finger may be on somewhere else, causing an offset between the user's finger and the cursor position. This CL fixes this problem by always moving the cursor to the finger's position when it's in direct input mode and the user is dragging around. BUG=628031 Committed: https://crrev.com/a18c11e644d679175ea864c7d0d45413d226144d Cr-Commit-Position: refs/heads/master@{#407060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Yuwei
ptal
4 years, 5 months ago (2016-07-21 19:19:41 UTC) #4
joedow
lgtm
4 years, 5 months ago (2016-07-22 03:38:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166423003/1
4 years, 5 months ago (2016-07-22 03:44:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 04:33:52 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 04:35:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a18c11e644d679175ea864c7d0d45413d226144d
Cr-Commit-Position: refs/heads/master@{#407060}

Powered by Google App Engine
This is Rietveld 408576698